Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Design Checklist for Conducting a Peer Review on Developer Work #3398

Open
3 tasks
SamiyahKey opened this issue Jan 24, 2025 · 0 comments
Open
3 tasks
Labels
design issue is for the design team

Comments

@SamiyahKey
Copy link

Story

As a designer,
I want to conduct a thorough peer review of developer work before it moves to production,
So that I can ensure design consistency, accessibility, and usability, while maintaining alignment between design and code.

Acceptance Criteria

  • The design review checklist in the PR template is updated to account for developer changes that do not have a corresponding Figma update.

  • The checklist follows code review best practices to ensure consistency, usability, and accessibility across the product.

  • Designers are equipped to document and track discrepancies between design and code.

Additional Context

Based on an Action Item assigned to @SamiyahKey from the Design Retro on 01/13/25

Issue Links

No response

@SamiyahKey SamiyahKey added design issue is for the design team story User stories labels Jan 24, 2025
@SamiyahKey SamiyahKey self-assigned this Jan 24, 2025
@PaulKuykendall PaulKuykendall moved this from 👶 New to 🍦 Backlog in .gov Product Board Jan 27, 2025
@PaulKuykendall PaulKuykendall removed the story User stories label Jan 27, 2025
@katypies katypies added this to the End of PoP handoff milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issue is for the design team
Projects
Status: 🍦 Backlog
Development

No branches or pull requests

3 participants