Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tool should not include cilium-cli-exclusive labelled PRs in changelog for cilium/cilium #272

Open
joestringer opened this issue Nov 1, 2024 · 2 comments

Comments

@joestringer
Copy link
Member

During #270 preparation, the changelog PR cilium/cilium@04a3a35 included a reference to cilium/cilium#35021 which is labelled as cilium-cli-exclusive, meaning that it has no impact on the cilium release. Therefore it shouldn't be included in the changelog for new cilium/cilium releases.

@chancez
Copy link
Contributor

chancez commented Nov 1, 2024

Im using the release tool in another repo that's bundling a few different separate "releasable" entities that need their own change logs, so this is relevant to me too. My initial thought is to use an include or exclude filter on a label that determines which entity is being released, but I haven't thought of it too deeply. For example using --label-filter $THE_ENTITY_BEING_RELEASED could work.

@joestringer
Copy link
Member Author

I like that idea. We could integrate that very easily into the github workflows we use in cilium/cilium for generating the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants