Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling when db is out of sync? #38

Open
mattpaz opened this issue Oct 21, 2015 · 1 comment
Open

Better error handling when db is out of sync? #38

mattpaz opened this issue Oct 21, 2015 · 1 comment
Assignees
Labels

Comments

@mattpaz
Copy link

mattpaz commented Oct 21, 2015

I copied code from on server to another and realized the db for ad positions was outta synch. It'd be great to have better error handling in cases like this.

Fatal error: Call to a member function get_position() on a non-object in
plugins/dfp-ads/includes/DFP_Ads.php on line 304

@chriswgerber
Copy link
Owner

I'll look into that. It looks like a simple change to that particular function. The function it's calling (to get the ad position object) returns false when it is unable to locate it. That false value is not dealt with correctly.

I'll get that added for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants