Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate merging most of chauncey-garrett/prezto back into upstream #26

Open
belak opened this issue Nov 9, 2017 · 2 comments
Open

Comments

@belak
Copy link

belak commented Nov 9, 2017

I've been looking at your fork since I ran across sorin-ionescu/prezto#914 and I was hoping to merge some of these changes back upstream as well as adding some of the new modules to the upcoming contrib repo.

Sorry for filing in your prompt repo but your prezto fork has issues disabled.

  1. Editor changes: sorin-ionescu/prezto@master...chauncey-garrett:master#diff-d47aedeec385fb4b85ecd505c23f9572
    These seem useful. One thing I'm not quite as sure about - I feel like the last block shouldn't set editor_info[overwrite] at all, unless I'm misunderstanding something. (I'm planning on committing these changes soon, if you don't have any objections)
  2. Don't display rbenv version if using system - I've already merged a similar version upstream in sorin-ionescu/prezto@c7dcd21
  3. General improvements to the utility module
    Most of this seems useful, though I don't understand the mnemonic for lld and lsd.
    I'd be happy to upstream this once those aliases are figured out.
  4. The garrett prompt - this is one of the better multi-line prompts I've seen and I'd love to have a way of including it... unfortunately we're in the middle of adding a contrib repo where we'd probably include most external modules. Once that's in, I would definitely be willing to include it in some sort of prompt-contrib module (We're hoping to move most themes to there, rather than including them in prezto-core) and might even be willing to include it directly in core eventually, given how good you've been about keeping your repos up to date.
  5. Your additional external modules - these would also be good fits for the contrib repo when it's ready

Please let me know if you have any thoughts on this. It would be great to get your opinion on some of the upcoming prezto changes because you seem to keep this prompt and your prezto pretty up to date.

@belak belak changed the title Look into merging chauncey-garrett/prezto with upstream Investigate merging most of chauncey-garrett/prezto back into upstream Nov 9, 2017
@chauncey-garrett
Copy link
Owner

No worries about the issues!

  1. I haven't used overwrite that much at all. It did used to exist in presto but was removed for some reason. The alternate (for vim command mode) setting on the other hand is quite useful when in vi mode. I use it in the prompt to change the direction of the arrows, letting you know that you're not in insert mode.
  2. Saw that! Thanks! I'm considering dropping support for ruby-info in the prompt. There's several reasons why:
    a. It seems slows down the prompt
    b. Supporting multiple languages would make the prompt too busy. There have been several who've forked and added their own language of choice
    c. I generally know what the environment of the project I'm working on is
    The improvement in upstream is a good one though so I'm glad to see it merged in.
  3. lld is like ll but only for dotfiles; ditto for lsd. So ls dotfiles. I've found it most useful in my home directory or the root of a git repo. I did find a regression in lld and have updated accordingly
  4. I'd be glad to have it in the core and am definitely open to improvements to it. One thing in particular is to async support so that the git calculation doesn't slow the prompt down. I also have a facelift branch that tweaks the look of the prompt I've been working on in my spare time. Check that out and let me know what you think!
  5. Glad to see external module support! I've been considering using zplug for this and now I may not have too!

@belak
Copy link
Author

belak commented Feb 14, 2018

Well, following up on this:

  1. I may look at merging your changes, especially if we don't support overwrite properly any more.
  2. Yeah, I'm not 100% happy with this either... still looking for a good portable async option.
  3. Ah, makes sense. I might snag those at some point.
  4. I'd be happy to include it in contrib (now that it's ready), either as an external theme, or directly - whichever you'd prefer.
  5. Yep, it's a little barebones at the moment, as I'd like to avoid building an entire plugin manager, but I've been merging stuff in for use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants