Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Add a CI to test conda-forge/cupy-feedstock? #576

Open
leofang opened this issue Apr 20, 2020 · 8 comments
Open

Add a CI to test conda-forge/cupy-feedstock? #576

leofang opened this issue Apr 20, 2020 · 8 comments
Assignees

Comments

@leofang
Copy link

leofang commented Apr 20, 2020

I am just throwing out some ideas for discussion. 🙂

As you may know, conda-forge's CIs do not have access to GPUs. So, we've been building packages in the dark and had hit bugs a few times. I am wondering if we could enable a CI in this repo that uses PFN's resources to do testing (as an extra safe).

I imagine we could do this:

  • use one of conda-forge's docker image (such as condaforge/linux-anvil-cuda:10.2)
  • install miniconda and all ingredients for conda-build
  • build the recipe from conda-forge/cupy-feedstock's master
  • test the built package locally by running CuPy's test suite

Likely we don't have to test the full build matrix; PY38 + CUDA 10.2 should provide a representative data point.

One thing I am wondering: If this could be set up, is it possible to invoke the CI here when conda-forge/cupy-feedstock gets new PRs?

Any thoughts?

cc: @jakirkham

@leofang leofang changed the title Add a real CI to test conda-forge/cupy-feedstock? Add a CI to test conda-forge/cupy-feedstock? Apr 21, 2020
@jakirkham
Copy link

FWIW the tests are actually included in the Conda package. So one can just run the tests like so.

conda build --test /datasets/jkirkham/miniconda/pkgs/cupy-7.3.0-py37h940342b_0.tar.bz2

@leofang
Copy link
Author

leofang commented Apr 27, 2020

I guess I was thinking testing the recipe against every PR.

@jakirkham
Copy link

Every PR against the conda-forge repo or every PR against CuPy?

@jakirkham
Copy link

There has been discussion periodically about uploading packages from PRs in conda-forge. Listed a few relevant threads below. There is also some work in other areas that may crossover with this need.

xref: conda-forge/conda-forge.github.io#124
xref: conda-forge/conda-forge.github.io#204
xref: conda-forge/conda-forge.github.io#647

@leofang
Copy link
Author

leofang commented Apr 28, 2020

Every CuPy PR if resource permits, if not then at least every CF PR. We don't have to upload from here; this just provides extra insurance and we can still use the current approach for uploading.

@kmaehashi kmaehashi self-assigned this May 12, 2020
@leofang
Copy link
Author

leofang commented Mar 10, 2021

@jakirkham My impression is the situation has changed and now RAPIDS uses gpuCI somewhere to test the CuPy conda package? If so then this is no longer needed. (I don't even remember I opened this...)

@jakirkham
Copy link

Nope this is still an issue. Though conda-forge is exploring this issue

@leofang
Copy link
Author

leofang commented Mar 13, 2021

Thanks, John! Just saw this new issue: conda-forge/conda-forge.github.io#1272.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants