Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6-shim dependency: upgrade? remove? #9

Open
dahjelle opened this issue Jul 18, 2017 · 3 comments
Open

es6-shim dependency: upgrade? remove? #9

dahjelle opened this issue Jul 18, 2017 · 3 comments

Comments

@dahjelle
Copy link
Contributor

I just found that having ssl-config as a dependency in our project was (indirectly) causing

console.log(new Set([1, 2, 3]);

to output

Set {}

instead of the expected values. Upgrading the es6-shim dependency to 0.35.3 fixed the issue.

So, it seems like the es6-shim dependency should be upgraded.

Alternatively, I didn't see an obvious requirement to use es6-shim—but it's very possible that I've been using ES6 so long I wouldn't recognize it anyway. Would it be possible to remove the dependency all together?

Thanks! Happy to help with a PR once a direction is decided.

@dahjelle
Copy link
Contributor Author

dahjelle commented Jan 9, 2018

I'm not sure if this was a conflict with Babel transpilation or their polyfill…either way, I had to remove this module today because of this issue. :-/ Still a good idea for a module, though!

@mikemaccana
Copy link
Collaborator

Hey @dahjelle I totally agree - I'll remopve es6-shim and publish a new version.

@dahjelle
Copy link
Contributor Author

@mikemaccana That'd be fantastic! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants