Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce csslint errors #2

Open
phette23 opened this issue Sep 20, 2014 · 2 comments
Open

Reduce csslint errors #2

phette23 opened this issue Sep 20, 2014 · 2 comments

Comments

@phette23
Copy link
Member

There are tons right now, mostly:

  • Use of !important which we really should try to limit, it's already backing us into a corner in places
  • Duplicate background images
  • Too many: floats, font-size declarations, heading selectors
  • Overqualified selectors (e.g. li.class where just .class might do)

We'll never get to 0 warnings & our CSS is bound to EQUELLA's structure, which makes many evils necessary. But we can do better.
@shacker
Copy link

shacker commented Sep 21, 2014

Eric, what are you using for CSS linting?

@phette23
Copy link
Member Author

csslint, specifically the Grunt csslint plug-in

@phette23 phette23 changed the title Work on reducing csslint errors Reduce csslint errors Feb 17, 2015
phette23 added a commit that referenced this issue Jun 10, 2021
@phette23
fix some easy SASS lint warnings, ref #2
987a753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shacker @phette23