Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The terminal colors don't match the catppuccin color palette. #70

Open
lixiaoyan opened this issue Jan 15, 2025 · 4 comments
Open

The terminal colors don't match the catppuccin color palette. #70

lixiaoyan opened this issue Jan 15, 2025 · 4 comments

Comments

@lixiaoyan
Copy link

https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md#terminals

image ⬅️ Zed ---- Ghostty ➡️
@uncenter
Copy link
Member

uncenter commented Jan 15, 2025

The Ghostty theme you are using is not made by us, and technically uses incorrect bright colors. Zed's terminal colors are correct, at least for now until Catppuccin's own recent ANSI colors improvements roll out: catppuccin/palette#98.

@lixiaoyan
Copy link
Author

lixiaoyan commented Jan 16, 2025

@uncenter The ANSI color improvement appears to have been released, correct? The PR you mentioned has been merged and some ports are already updated to match the new colors. And I think the Ghostty theme is basically official (or semi-official), as it is mentioned in our repo.

@lixiaoyan
Copy link
Author

@uncenter
Copy link
Member

uncenter commented Jan 16, 2025

The ANSI color improvement appears to have been released, correct?

They were just released a few months ago.

The PR you mentioned has been merged and some ports are already updated to match the new colors.

The ANSI colors aren't even available in our primary in-house templating tool: catppuccin/whiskers#66. Zed uses Whiskers to build the theme here, so that isn't really a possibility.

And I think the Ghostty theme is basically official (or semi-official), as it is mentioned in our repo.

There is nothing stated about "officiality" in that README. It only says "Catppuccin is included". We have zero executive control over the themes in the https://github.com/mbadolato/iTerm2-Color-Schemes repository besides making PRs (which we don't really do).

I confirmed that the Ghostty theme matches our new ANSI colors. catppuccin/palette@v1.7.1/palette.json mbadolato/iTerm2-Color-Schemes@38783f2/ghostty/catppuccin-latte

Looks like someone made this PR after the ANSI colors release: mbadolato/iTerm2-Color-Schemes#454.

As stated before, the ANSI color rollout is slow will continue to be slow as we adopt it across tens/hundreds of ports. No point in making issues on every one of them, this repository will get updated when it is available to it. I already have a draft up for it in Ghostty specifically, but no timeline: catppuccin/ghostty#7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants