Sourceasset to assetspec #3983

ggurjar333 · 2024-12-03T06:46:29Z

Overview

Closes #3977.

What problem does this address?

What did you change?

Documentation

Make sure to update relevant aspects of the documentation.

Tasks

Give feedback

Update the release notes: reference the PR and related issues.
Update relevant Data Source jinja templates (see docs/data_sources/templates).
Update relevant table or source description metadata (see src/metadata).
Review and update any other aspects of the documentation that might be affected by this PR.
Options

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Give feedback

If updating analyses or data processing functions: make sure to update or write data validation tests (e.g. test_minmax_rows()).
Run make pytest-coverage locally to ensure that the merge queue will accept your PR.
Review the PR yourself and call out any questions or issues you have.
For minor ETL changes or data additions, once make pytest-coverage passes, make sure you have a fresh full PUDL DB downloaded locally, materialize new/changed assets and all their downstream assets and run relevant data validation tests using pytest and --live-dbs.
For bigger ETL or data changes run the full ETL locally and then run the data validations using make pytest-validate.
Alternatively, run the build-deploy-pudl GitHub Action manually.
Options

…improved clarity and consistency

src/pudl/extract/ferc1.py

…1 assets

…r asset initialization

For more information, see https://pre-commit.ci

ggurjar333 added 2 commits November 24, 2024 16:37

Refactor asset definitions to replace SourceAsset with AssetSpec for …

184aa2d

…improved clarity and consistency

Merge branch 'catalyst-cooperative:main' into sourceasset-to-assetspec

470811e

ggurjar333 mentioned this pull request Dec 3, 2024

Switch from using the deprecated SourceAsset to AssetSpec #3977

Open

jdangerx reviewed Dec 17, 2024

View reviewed changes

src/pudl/extract/ferc1.py Outdated Show resolved Hide resolved

ggurjar333 added 2 commits February 1, 2025 18:38

Merge branch 'catalyst-cooperative:main' into sourceasset-to-assetspec

69080e3

Refactor AssetSpec initialization to use with_io_manager_key for FERC…

6d6b10f

…1 assets

ggurjar333 marked this pull request as ready for review February 2, 2025 06:52

ggurjar333 and others added 3 commits February 2, 2025 10:59

Refactor create_raw_ferc714_xbrl_assets to use with_io_manager_key fo…

b25025d

…r asset initialization

[pre-commit.ci] auto fixes from pre-commit.com hooks

b0c4163

For more information, see https://pre-commit.ci

Merge branch 'main' into sourceasset-to-assetspec

92c3edf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourceasset to assetspec #3983

Sourceasset to assetspec #3983

ggurjar333 commented Dec 3, 2024 •

edited by jdangerx

Loading

Tasks

To-do list

Sourceasset to assetspec #3983

Are you sure you want to change the base?

Sourceasset to assetspec #3983

Conversation

ggurjar333 commented Dec 3, 2024 • edited by jdangerx Loading

Overview

What problem does this address?

What did you change?

Documentation

Tasks

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

ggurjar333 commented Dec 3, 2024 •

edited by jdangerx

Loading