Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error upgrading contract to 1.5.0 #261

Closed
davidatwhiletrue opened this issue Dec 29, 2023 · 0 comments · Fixed by #263
Closed

Error upgrading contract to 1.5.0 #261

davidatwhiletrue opened this issue Dec 29, 2023 · 0 comments · Fixed by #263
Assignees
@gRoussac

Comments

@davidatwhiletrue
Copy link
Collaborator

davidatwhiletrue commented Dec 29, 2023 •
edited
Loading

It seems not possible to upgrade a contract to 1.5.0 when the current version already has CES events enabled (and you want to keep it enabled).

Possibly, the problem is that the migrate() method tries to reinitialize CES keys and that leads to an error.

cep-78-enhanced-nft/contract/src/main.rs

Line 2016 in 9f7aeac

utils::init_events();

I guess events_mode should be an optional runtime argument when migrating the contract. And keep the current mode if argument is omitted.
gRoussac added a commit to gRoussac/cep-78-enhanced-nft that referenced this issue Dec 29, 2023
@gRoussac
Fix casper-ecosystem#261 Failure on migration when EventsMode::CES to…
53781b5 
… EventsMode::CES
@gRoussac gRoussac mentioned this issue Dec 29, 2023
Closed
gRoussac added a commit to gRoussac/cep-78-enhanced-nft that referenced this issue Dec 29, 2023
@gRoussac
Fix casper-ecosystem#261 Failure on migration when EventsMode::CES to…
cc9e1fa 
… EventsMode::CES
@gRoussac gRoussac mentioned this issue Dec 29, 2023
Merged
@gRoussac gRoussac linked a pull request Dec 29, 2023 that will close this issue
Fix #261 Failure on migration when EventsMode::CES to EventsMode::CES #263
Merged
@gRoussac gRoussac mentioned this issue Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gRoussac gRoussac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #261 Failure on migration when EventsMode::CES to EventsMode::CES gRoussac/cep-78-enhanced-nft
2 participants
@davidatwhiletrue @gRoussac