Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-09-10: "source" | "sources" #81

Open
tobyhodges opened this issue Sep 10, 2020 · 1 comment
Open

2020-09-10: "source" | "sources" #81

tobyhodges opened this issue Sep 10, 2020 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@tobyhodges
Copy link
Member

The README states

glossary:
  sources:
  - http://some_glossary.org/something/
  language: fr
  requires:
  - aggregation_function
  - call_stack
  defines:
  - closure
  - name_collision
  1. The source key is required.

which seems internally inconsistent. Should the lesson metadata have key source or sources?

@tobyhodges tobyhodges added the question Further information is requested label Sep 10, 2020
@ian-flores
Copy link
Member

@tobyhodges the R package is currently using neither. It uses base_url as its parameter. I'll modify it so that it is sources as per conversations with @gvwilson we are now trying to support multiple glosario sources

@ian-flores ian-flores self-assigned this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants