Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to poetry #2737

Closed
pbanaszkiewicz opened this issue Jan 10, 2025 · 0 comments · Fixed by #2756
Closed

Switch to poetry #2737

pbanaszkiewicz opened this issue Jan 10, 2025 · 0 comments · Fixed by #2756
Assignees
Labels
component: deployment component: documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code
Milestone

Comments

@pbanaszkiewicz
Copy link
Contributor

Switch from pipenv to poetry.

Recently there were some issues with Dependabot and pipenv, so maybe it's time to switch.

@pbanaszkiewicz pbanaszkiewicz added component: deployment component: documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 10, 2025
@pbanaszkiewicz pbanaszkiewicz added this to the v4.6 milestone Jan 10, 2025
@pbanaszkiewicz pbanaszkiewicz self-assigned this Jan 10, 2025
@pbanaszkiewicz pbanaszkiewicz modified the milestones: v4.6, v4.7 Jan 14, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 8, 2025
This was referenced Feb 8, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
There's a pending error in that library, similar to typeddjango/django-stubs#2479.

Unfortunately the upgrade didn't help, developers may have to use `--no-verify` when committing.
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
This indicates what is required in `manage.py test` command to run correctly.

The path is required because `amy/` directory is not a package (doesn't contain `__init__.py` file), which isn't supported by unittest discovery:
https://docs.python.org/3/library/unittest.html#test-discovery (see note at the end of the linked section).
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
Unified to 1 function for handling next or default URL, 1 function for confirming if URL is safe. Added tests and improved some typing.
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: deployment component: documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant