Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to poetry #2737

Open
pbanaszkiewicz opened this issue Jan 10, 2025 · 0 comments · May be fixed by #2756
Open

Switch to poetry #2737

pbanaszkiewicz opened this issue Jan 10, 2025 · 0 comments · May be fixed by #2756
Assignees
@pbanaszkiewicz
Labels
component: deployment component: documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code
Milestone
v4.7

Comments

@pbanaszkiewicz
Copy link
Contributor

Switch from pipenv to poetry.

Recently there were some issues with Dependabot and pipenv, so maybe it's time to switch.
@pbanaszkiewicz pbanaszkiewicz added component: deployment component: documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 10, 2025
@pbanaszkiewicz pbanaszkiewicz added this to the v4.6 milestone Jan 10, 2025
@pbanaszkiewicz pbanaszkiewicz self-assigned this Jan 10, 2025
@pbanaszkiewicz pbanaszkiewicz modified the milestones: v4.6, v4.7 Jan 14, 2025
pbanaszkiewicz added a commit that referenced this issue Feb 8, 2025
@pbanaszkiewicz
feat(#2737): Add poetry.lock and poetry dependencies in pyproject.toml
ff18f21
pbanaszkiewicz added a commit that referenced this issue Feb 8, 2025
@pbanaszkiewicz
feat(#2737): Change imports/settings according to updated dependencies
4c76131
pbanaszkiewicz added a commit that referenced this issue Feb 8, 2025
@pbanaszkiewicz
feat(#2737): Update bootstrap4 templates to be compatible with upstre…
c40ad2f 
…am template package
pbanaszkiewicz added a commit that referenced this issue Feb 8, 2025
@pbanaszkiewicz
fix(#2737): Remove <b> that was causing some forms to render with t…
92b1f32 
…oo much bold
pbanaszkiewicz added a commit that referenced this issue Feb 8, 2025
@pbanaszkiewicz
fix(#2737): Improve ReCaptcha display
902a6b0
pbanaszkiewicz added a commit that referenced this issue Feb 8, 2025
@pbanaszkiewicz
feat(#2737): Change settings
75a487a
This was referenced Feb 8, 2025
Draft
Open
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Update settings, bump Python to 3.12, allow long lines (…
68831d0 
…120)
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Reformat for Flake8 and Black, use longer lines (120)
3e79950
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Update pre-commit configuration, black, flake8 and mypy
fbed6fd 
Mypy is from now on in full strict mode.
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): For mypy compatibility, switch to pyproject.toml versioning
f04a54c
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Update Dockerfile and start.sh with poetry instructions
4c8192e
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Switch to Poetry in CI pipelines
db458d9
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Switch to Poetry in CI pipelines
53bd5a2
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Attempt to fix linter pipeline...
8cb3c26
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Update actions/checkout version
2e1e7bf
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Update actions/setup-python version and poetry installat…
3568b8d 
…ion cmds
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Testing test stage
6352bc2
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Making the tests run
41f937e
pbanaszkiewicz added a commit that referenced this issue Feb 11, 2025
@pbanaszkiewicz
feat(#2737): Remove Pipfile and Pipfile.lock
521f2f4
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Update mypy
0569c47
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Rename LANG="en_US.UTF-8"
6db4737 
LC_COLLATE="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_ALL= to  due to name conflict with Python stdlib
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Update django-stubs
2394df9 
There's a pending error in that library, similar to typeddjango/django-stubs#2479.

Unfortunately the upgrade didn't help, developers may have to use `--no-verify` when committing.
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Fix tests
9a42416
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Add instructions for running tests
d7c5d76
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Update mypy
53d76ed
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Rename locale to formats due to name conflict with P…
90e1c8f 
…ython stdlib
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Update django-stubs
2b4d7a5 
There's a pending error in that library, similar to typeddjango/django-stubs#2479.

Unfortunately the upgrade didn't help, developers may have to use `--no-verify` when committing.
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Fix tests
07a5976
pbanaszkiewicz added a commit that referenced this issue Feb 12, 2025
@pbanaszkiewicz
feat(#2737): Add instructions for running tests
50fcfdc
pbanaszkiewicz added a commit that referenced this issue Feb 13, 2025
@pbanaszkiewicz
feat(#2737): Explicit directory path in test commands
ad88d13 
This indicates what is required in `manage.py test` command to run correctly.

The path is required because `amy/` directory is not a package (doesn't contain `__init__.py` file), which isn't supported by unittest discovery:
https://docs.python.org/3/library/unittest.html#test-discovery (see note at the end of the linked section).
pbanaszkiewicz added a commit that referenced this issue Feb 14, 2025
@pbanaszkiewicz
feat(#2737): Improve typing in metadata utils
8769b45
pbanaszkiewicz added a commit that referenced this issue Feb 14, 2025
@pbanaszkiewicz
fix(#2737): Polynomial regular expression used on uncontrolled data
467cb68 
Fix for CodeQL scan.
pbanaszkiewicz added a commit that referenced this issue Feb 14, 2025
@pbanaszkiewicz
fix(#2737): Safe redirect handling
4f8496a 
Unified to 1 function for handling next or default URL, 1 function for confirming if URL is safe. Added tests and improved some typing.
pbanaszkiewicz added a commit that referenced this issue Feb 14, 2025
@pbanaszkiewicz
fix(#2737): Safe redirect handling
df08a96 
Unified to 1 function for handling next or default URL, 1 function for confirming if URL is safe. Added tests and improved some typing.
pbanaszkiewicz added a commit that referenced this issue Feb 14, 2025
@pbanaszkiewicz
fix(#2737): Fix tests
25181f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbanaszkiewicz pbanaszkiewicz

Labels
component: deployment component: documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Milestone
v4.7
Development

Successfully merging a pull request may close this issue.

Switch to Poetry carpentries/amy
1 participant
@pbanaszkiewicz