Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] Switch to QXmlStreamReader #210

Open
suamor opened this issue Nov 19, 2024 · 0 comments
Open

[Deprecation] Switch to QXmlStreamReader #210

suamor opened this issue Nov 19, 2024 · 0 comments
Labels
compilation compilation warnings and abnormalities

Comments

@suamor
Copy link
Collaborator

suamor commented Nov 19, 2024

Description:
On Ubuntu 24.04 there are a lot of deprecation warnings. Not a problem with Qt5 but since Qt5 will be removed in the near future, we probably need to switch to QXmlStreamReader.

Warnings: (not all listed, but basically all import and export classes using xml)
/home/suamor/projekte/canorus/gh/canorus/src/import/canorusmlimport.h:36:51: warning: 'QXmlDefaultHandler' is deprecated [-Wdeprecated-declarations]
36 | class CACanorusMLImport : public CAImport, public QXmlDefaultHandler {

In file included from /home/suamor/projekte/canorus/gh/build-canorus-Qt5_15_2-Debug/src/canoruspythonPYTHON_wrap.cxx:3983:
/home/suamor/projekte/canorus/gh/canorus/src/import/canorusmlimport.h:50:27: warning: 'QXmlParseException' is deprecated [-Wdeprecated-declarations]
50 | bool fatalError(const QXmlParseException& exception);

In file included from /home/suamor/projekte/canorus/gh/build-canorus-Qt5_15_2-Debug/src/canoruspythonPYTHON_wrap.cxx:4003:
/home/suamor/projekte/canorus/gh/canorus/src/interface/pluginmanager.h:25:32: warning: 'QXmlDefaultHandler' is deprecated [-Wdeprecated-declarations]
25 | class CAPluginManager : public QXmlDefaultHandler

In file included from /home/suamor/projekte/canorus/gh/canorus/src/interface/pluginmanager.cpp:16:
/home/suamor/projekte/canorus/gh/canorus/src/interface/pluginmanager.h:52:27: warning: 'QXmlParseException' is deprecated [-Wdeprecated-declarations]
52 | bool fatalError(const QXmlParseException& exception);

ToDo:
While normally these warnings could just be ignored for now they generate a huge amount of noise so that important warnings get easily overlooked. I'm even thinking of temporarily suppressing deprecation warnings.

DoD:
QXmlStreamReader implemented in all mentioned classes

Alternatively:
Switch to Qt 6.5 (which requires other porting work)

@suamor suamor added the compilation compilation warnings and abnormalities label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compilation compilation warnings and abnormalities
Projects
None yet
Development

No branches or pull requests

1 participant