We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The chart currently does not incorporate several recommended best practices such as:
imagePullSecrets
securityContext
affinity
tolerations
gRPC
TChannel
RPC
Inspiration Banzai:
Temporal:
gRPC:
{{- range $service := (list "frontend" "matching" "history" "worker") }} {{- $serviceValues := index $.Values.server $service -}} apiVersion: v1 kind: Service metadata: name: {{ include "cadence.componentname" (list $ (printf "%s-headless" $service)) }} labels: # labels annotations: #annotations spec: type: ClusterIP clusterIP: None publishNotReadyAddresses: true ports: - port: {{ $serviceValues.service.port }} targetPort: rpc protocol: TCP name: rpc {{- /* All services but the worker have a gRPC port. */ -}} {{- if (ne $service "worker") }} - port: {{ $serviceValues.service.grpcPort }} targetPort: grpc protocol: TCP name: grpc {{- end }} {{- if $.Values.metricsEnabled }} - name: metrics port: {{ $.Values.services.metrics.port }} targetPort: metrics protocol: TCP {{- end }} selector: app.kubernetes.io/name: {{ include "cadence.name" $ }} app.kubernetes.io/instance: {{ $.Release.Name }} app.kubernetes.io/component: {{ $service }} --- {{- end }}
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The chart currently does not incorporate several recommended best practices such as:
imagePullSecrets
: allowing the image to be hosted and pulled from a private registrysecurityContext
: enabling containers run as non-root and follow principle of least privilegeaffinity
for controlling pod placement.tolerations
: for scheduling pods to tolerate specific conditions.gRPC
where possible: prefer to usegRPC
overTChannel
(RPC
) due to it being more standardized.Inspiration
Banzai:
Temporal:
gRPC:
The text was updated successfully, but these errors were encountered: