From 40d3f174470c1061f91efffd015e4d715deb59e5 Mon Sep 17 00:00:00 2001 From: Bas Kamer Date: Tue, 3 Feb 2015 15:35:54 +0100 Subject: [PATCH] minor changes via scrutinizr --- src/Service/Factory/PhingServiceFactory.php | 6 +++++- src/Service/PhingService.php | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Service/Factory/PhingServiceFactory.php b/src/Service/Factory/PhingServiceFactory.php index 4878422..8d578ce 100644 --- a/src/Service/Factory/PhingServiceFactory.php +++ b/src/Service/Factory/PhingServiceFactory.php @@ -2,6 +2,8 @@ namespace BsbPhingService\Service\Factory; +use BsbPhingService\Options\PhingOptions; +use BsbPhingService\Options\ServiceOptions; use BsbPhingService\Service\PhingService; use Zend\ServiceManager\FactoryInterface; use Zend\ServiceManager\ServiceLocatorInterface; @@ -16,7 +18,9 @@ class PhingServiceFactory implements FactoryInterface */ public function createService(ServiceLocatorInterface $serviceLocator) { - $options = $serviceLocator->get('BsbPhingService.serviceOptions'); + /** @var ServiceOptions $options */ + $options = $serviceLocator->get('BsbPhingService.serviceOptions'); + /** @var PhingOptions $phingOptions */ $phingOptions = $serviceLocator->get('BsbPhingService.phingOptions'); return new PhingService($options, $phingOptions); diff --git a/src/Service/PhingService.php b/src/Service/PhingService.php index 4ccd995..f6ae14d 100644 --- a/src/Service/PhingService.php +++ b/src/Service/PhingService.php @@ -57,7 +57,7 @@ public function getPhingOptions() * * @return Process */ - public function build($target = "", $options = null, $immediate = true) + public function build($targets = "", $options = null, $immediate = true) { $phingOptions = clone $this->phingOptions; @@ -65,7 +65,7 @@ public function build($target = "", $options = null, $immediate = true) $phingOptions->setFromArray($options); } - $process = $this->createProcessInstance($target, $phingOptions); + $process = $this->createProcessInstance($targets, $phingOptions); if ($immediate) { $process->run();