From ed778be8748fae0d1a0ebb552a99c7f0e60fdf33 Mon Sep 17 00:00:00 2001 From: Alex Moinet Date: Mon, 9 Oct 2023 10:45:00 +0100 Subject: [PATCH] Ensure makefile works correctly when updating cake file version --- .github/workflows/update-dependencies.yml | 2 +- Makefile | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/update-dependencies.yml b/.github/workflows/update-dependencies.yml index 709fe1c8b..a873d3bf6 100644 --- a/.github/workflows/update-dependencies.yml +++ b/.github/workflows/update-dependencies.yml @@ -43,6 +43,6 @@ jobs: run: > gh pr create -B dep-updater -H bumpsnag-$TARGET_SUBMODULE-$TARGET_VERSION - --title 'Update $TARGET_SUBMODULE to version $TARGET_VERSION' + --title "Update $(TARGET_SUBMODULE) to version $(TARGET_VERSION)" --body 'Created by bumpsnag' --reviewer cawllec diff --git a/Makefile b/Makefile index f27f48a84..3ceaf452d 100644 --- a/Makefile +++ b/Makefile @@ -10,8 +10,8 @@ bump_cake: ifeq ($(VERSION),) @$(error VERSION is not defined. Run with `make VERSION=number bump_cake`) endif - if [[ "$OSTYPE" == "darwin"* ]]; then - @sed -i '' "s/^var version = \".*\";/var version = \"$(VERSION)\";/" build.cake - else - @sed -i "s/^var version = \".*\";/var version = \"$(VERSION)\";/" build.cake - fi \ No newline at end of file +ifeq ($(OSTYPE), $(wildcard darwin*)) + @sed -i '' "s/^var version = \".*\";/var version = \"$(VERSION)\";/" build.cake +else + @sed -i "s/^var version = \".*\";/var version = \"$(VERSION)\";/" build.cake +endif