addrv2: rust-bitcoin returns invalid torv2 address

[brunoerg]

I just got a crash in addrv2 (#48) target because when deserializing addrv2 addresses rust-bitcoin checks whether TorV2 address is valid and throws an error if it is invalid. However, when deserializing an addrv2, Bitcoin Core doesn't validate TorV2 anymore (Core removed support for torv2 - bitcoin/bitcoin#22050) and simply ignore it. So, the message is valid but the addr is ignored.

3 => {
    if len != 10 {
        return Err(encode::Error::ParseFailed("Invalid TorV2 address"));
    }
    let id = Decodable::consensus_decode(r)?;
    AddrV2::TorV2(id)
}

However, it might be an issue in Bitcoin Core, because even not supporting torv2, it should validate the length according to the BIP.

[brunoerg]

hmmm

https://github.com/bitcoin/bitcoin/pull/22050/files#r645432156

[apoelstra]

I'd consider this an upstream issue. Though for us, maybe we should drop TorV2 support.

[brunoerg]

Sounds good to drop TorV2 support, it's basically useless.