@zhaizhai ha, that is quite interesting!

@dominictarr thoughts? Haha.
@calvinmetcalf I guess we could just white list in package.json.

"files": [
  "browser.js",
  ...
]

However, maybe renaming the files will be just as effective and maintains a status quo?

Hmm, if you bundle this with browserify then you won't need to keep node_modules at all.
Am I missing something?

We can just put *. pem in a .npmignore

On Sat, Jun 6, 2015, 5:32 AM Dominic Tarr [email protected] wrote:

Hmm, if you bundle this with browserify then you won't need to keep
node_modules at all.
Am I missing something?

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

first we should understand why this is causing @zhaizhai's problem

@dominictarr Good point, you're right that I don't need to package node_modules in this case. So never mind, it doesn't matter for me. Thanks for responding so quickly!

👍

@zhaizhai how were you packaging node_modules in the first place?

I know this is a little late, but I was hitting this problem today. I am developing a chrome extension that depends on browserify. Chrome throws the following errors when trying to unpack the extension:

This extension includes the key file '/app/node_modules/browserify/node_modules/crypto-browserify/node_modules/public-encrypt/test/test_key.pem'. You probably don't want to do that.
This extension includes the key file '/app/node_modules/browserify/node_modules/crypto-browserify/node_modules/public-encrypt/test/test_rsa_privkey.pem'. You probably don't want to do that.
This extension includes the key file 'app/node_modules/browserify/node_modules/crypto-browserify/node_modules/public-encrypt/test/test_rsa_pubkey.pem'. You probably don't want to do that.

I removed the files manually and all was well. However, the next time I run npm install I will hit the same issue. I was thinking maybe adding the test directory to .npmignore would do the trick.

@RobbyChapman if you are using browserify, why is the node_modules in the application directory at all?

@dcousens I'm not sure I understand the question. If you are building a chrome extension the entire root directory is the application. Moving node modules wouldn't solve that.

@RobbyChapman the contents of node_modules especially node_modules/browserify is a development dependency that should not actually be packed into the chrome extension, though as you are the 2nd one to make this mistake it probably wouldn't hurt to put the .pem files into the npm ignore

@dcousens I see what you are saying. I rearrange the app based on your suggestion and all is well. I do agree with the .pem fix though. Thanks for looking into it!

@RobbyChapman we could move it, but this sounds like a great way to help people realise you shouldn't pack node_modules, especially since there is no reason to ignore the PEM files otherwise.
If we want to not include the tests folder, that is another issue.

@dcousens I'm developing a Chrome extension. I know I shouldn't pack node_modules, but when I'm developing the app I usually have manifest.json, /src and node_modules all on top level, and load the extension from the project root. When I'm publishing I only copy over the built files and manifest.json into a publish folder.

I'll send another PR that just npm-ignores the test/ folder. Hope you can publish a new version. Thanks!