We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File location:chirpstack-network-server/internal/data/data.go
chirpstack-network-server/internal/data/data.go
Source code:
func setPingSlotParameters(ctx *dataContext) error { if !ctx.DeviceProfile.SupportsClassB { return nil } if classBPingSlotDR != ctx.DeviceSession.PingSlotDR || classBPingSlotFrequency != ctx.DeviceSession.PingSlotFrequency { block := maccommand.RequestPingSlotChannel(ctx.DeviceSession.DevEUI, classBPingSlotDR, classBPingSlotFrequency) ctx.MACCommands = append(ctx.MACCommands, block) } return nil }
Bug:
if classBPingSlotDR != ctx.DeviceSession.PingSlotDR || classBPingSlotFrequency != ctx.DeviceSession.PingSlotFrequency { block := maccommand.RequestPingSlotChannel(ctx.DeviceSession.DevEUI, classBPingSlotDR, classBPingSlotFrequency) ctx.MACCommands = append(ctx.MACCommands, block) }
According to my opinion,PingSlotDR/classBPingSlotFrequency always loading from chirpstack-network-server.toml, not loading from ctx.DeviceSession.
PingSlotDR/classBPingSlotFrequency
chirpstack-network-server.toml
ctx.DeviceSession
My Patch is:
var classBPingSlotDRReal int if classBPingSlotDR != ctx.DeviceSession.PingSlotDR { classBPingSlotDRReal = ctx.DeviceSession.PingSlotDR }else { classBPingSlotDRReal = classBPingSlotDR } var classBPingSlotFrequencyReal uint32 if classBPingSlotFrequency != ctx.DeviceSession.PingSlotFrequency { classBPingSlotFrequencyReal = ctx.DeviceSession.PingSlotFrequency }else { classBPingSlotFrequencyReal = classBPingSlotFrequency } block := maccommand.RequestPingSlotChannel(ctx.DeviceSession.DevEUI, classBPingSlotDRReal, classBPingSlotFrequencyReal) ctx.MACCommands = append(ctx.MACCommands, block)
Is my idea correct? Looking forward to your reply:)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
File location:
chirpstack-network-server/internal/data/data.go
Source code:
Bug:
According to my opinion,
PingSlotDR/classBPingSlotFrequency
always loading fromchirpstack-network-server.toml
, not loading fromctx.DeviceSession
.My Patch is:
Is my idea correct? Looking forward to your reply:)
The text was updated successfully, but these errors were encountered: