Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemProvider's Items are edited by ShopGuiPlus #29

Open
emanondev opened this issue Apr 29, 2022 · 2 comments
Open

ItemProvider's Items are edited by ShopGuiPlus #29

emanondev opened this issue Apr 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@emanondev
Copy link

Items given by ItemProvider are changed after ItemProvider provide them

Example if ItemProvider provide a POTION (Material) item with no base potion effects like water bottle, the base potion data is changed and a INSTANT_HEAL as Base Effect is added

Steps to reproduce:

  1. Create an item provider as specified
  2. On loadItem() return a water bottle
  3. Put that item on a Shop and reload the plugin
  4. Open the shop and see that your water bottle gained INSTANT_HEAL effect

Server version: git-Paper-299 (MC: 1.18.2)
ShopGuiPlus: 1.76.0
@brcdev brcdev added the bug Something isn't working label Jun 20, 2022
@brcdev
Copy link
Member

brcdev commented Jun 20, 2022

Needs investigation

@brcdev
Copy link
Member

brcdev commented Aug 7, 2022

Bug confirmed. It's not just API bug, it affects items added in regular way as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brcdev @emanondev