Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @property for magic getters in Results #311

Closed
dretsa opened this issue Jan 11, 2022 · 2 comments
Closed

Add @property for magic getters in Results #311

dretsa opened this issue Jan 11, 2022 · 2 comments

Comments

@dretsa
Copy link

dretsa commented Jan 11, 2022

General information

  • SDK/Library version: 6.5.1
  • Environment: Both
  • Language, language version, and OS: PHP 8.1 - Linux amd64

Issue description

PHPStan is going mental when analysing analysing results from $gateway->transaction()->sale(...), because there are no doocs. Would be nice there was PHPDoc @property annotations on at least Transaction and Error classes.
@dretsa dretsa changed the title Add @propery for magic getters in Results Add @property for magic getters in Results Jan 11, 2022
@slt
Copy link
Contributor

slt commented Mar 7, 2022

Hi I am having this same issue - seems to be the same as issue #310
These did exist prior to 6.5.0 but were stripped out in e35c2a2

@hollabaq86
Copy link
Contributor

Hey folks, going to close this issue as it is the same as #310. Will move conversation there

hollabaq86 pushed a commit that referenced this issue Jan 11, 2023
Major Version 6 (#324)
97b0b30 
* set to php 7.2 in sdk docker image to get tests running

* Add unit tests for RiskData

* drop RiskDataScore integration check

* update README

* Require PHP >=7.3.0 (#309)

* Update README.md

* Remove AmexExpressCheckout

* Remove deviceSessionID and fraudMerchantID from lib/

* Update CreditCardTest integration

* Remove deviceSessionID and fraudMerchantID from rest of tests

* Remove masterpass (#311)

* Remove MasterpassCard, MasterpassCardDetails, and relevant tests

* Address remaining NEXT_MAJOR_VERSION notes (#314)
* Rename isUsingInstanceProxy to isUsingProxy
* Rename isAuthenticatedInstanceProxy to isAuthenticatedProxy
* Remove TRANSACTION_EXTERNAL_VAULT_CARD_TYPE_IS_INVALID  error code
* Remove snake case parameters

* Rename Android Pay to Google Pay (#310)

* Php 8 support (#308)

* update docker image to php8.0

* bump phpunit to >=9.0

* setUp and teardown must be void compatible

* rename CloseTagTest, fix breaking changes from phpunit7-> 9 in unit tests

* address phpunit deprecation warnings

* make integration tests setUp void compatible

* fix breaking changes in integration tests

* update tests to resolve deprecation warnings

* Don't create phpunit cache file

* correct phpunit semver in composer.json

* add phpunit result cache to gitignore just in case

* update Dockerfile for php8

* Audit sanity language use

* Rename isUsingInstanceProxy to isUsingProxy

* Rename isAuthenticatedInstanceProxy to isAuthenticatedProxy

* Remove TRANSACTION_EXTERNAL_VAULT_CARD_TYPE_IS_INVALID  error code

* better name for test to check we're omitting php closing tags

* fixup deprecated tests from result of merging major update branch

* DateTimeImmutable support (public issue #278) (#316)

* Remove TRANSACTION_EXTERNAL_VAULT_CARD_TYPE_IS_INVALID  error code

* support DateTimeImmutableObjects for date params

* Add `toArray` function to Base and Instance classes (resolves #289?) (#322)

* Final tweaks - Major version 6 (#323)

Co-authored-by: Samantha Cannillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slt @hollabaq86 @dretsa