Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Provide "auto" compression also with "zstd", not only "zlib" and "lzma" #2202

Open
tvogel opened this issue Feb 9, 2025 · 1 comment

Comments

@tvogel
Copy link

tvogel commented Feb 9, 2025

The problem

The discussion here
borgbackup/borg#7054
quite clearly showed that even for zstd, using auto makes for a significant performance improvement and ultimately contributed to keeping the auto feature in borgbackup. So, it's unfortunate that I cannot easily select auto modes with zstd in Vorta.

Requested Solution

Adding the auto variants here should be easy and straight forward:

self.repoCompression.addItem(self.tr('Zstandard Level 3 (modern)'), 'zstd,3')

Alternatives

In #1445, an alternative solution was proposed to add the "auto" option as a checkbox and the compression level as a slider.

Personally, I like the approach to limit the choices to a reasonable set of options. That's why I propose to just add auto,zstd,3 and auto,zstd,8. A little more context to make the decision easier would be helpful (e.g. links to compression benchmarks).

Using a checkbox (without mitigations) would allow people to make useless choices like auto,none or auto,lz4.

@madeddy
Copy link

madeddy commented Feb 21, 2025

The discussion here borgbackup/borg#7054 quite clearly showed that even for zstd, using auto makes for a significant performance improvement

Beats me why this is missing for zstd. A mistake?

Personally, I like the approach to limit the choices to a reasonable set of options.

I tend to agree. But to have so few compressions options, e.g. just two for zstd (3, 8) out of 0 to 22, is IMO strange at least, if not unlogical and not this bright.

Bottomline: "Auto" should absolutely be added and a few more spread out level options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants