Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Readme.md Walkthrough Steps - nRF 15.2.0 #11

Open
jacobgqc opened this issue Jan 8, 2019 · 3 comments
Open

Error in Readme.md Walkthrough Steps - nRF 15.2.0 #11

jacobgqc opened this issue Jan 8, 2019 · 3 comments

Comments

@jacobgqc
Copy link

jacobgqc commented Jan 8, 2019

As written, the walkthrough does not work. At the end of Step 3 you should be able to connect to the peripheral, but I wasn't able to. The missing steps appear to be the addition of QWR Queued Write Module. After adding the QWR logic to my services_init method I'm able to connect to the peripheral.

Thanks for the great walkthrough!

@jacobgqc
Copy link
Author

jacobgqc commented Jan 8, 2019

Another possible issue with the walkthrough text. In Step 4, it isn't explicitly stated to define custom_value_char_add() method in the header file, or in the c file before it is used.

Edited:
Never mind this comment, none of the steps explicitly mention the method ordering. Since this is common C functionality I'm assuming it's on the users to know or figure out.

Thanks again for the walkthrough, it's helped me immensely.

@Ger-zal
Copy link

Ger-zal commented Mar 7, 2019

Got the same issue, @jacobgqc how did you

After adding the QWR logic to my services_init method I'm able to connect to the peripheral.

Because im struggling with this part and I didnt get it.

@jacobgqc
Copy link
Author

jacobgqc commented Mar 8, 2019

@youhou90 If you look at the main.c file and do a search on qwr you should be able to see the lines you need to add.
In particular, the services_init method has:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants