Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corruption with addLine but not addRGB565Line #16

Open
prplz opened this issue Jan 25, 2024 · 3 comments
Open

Corruption with addLine but not addRGB565Line #16

prplz opened this issue Jan 25, 2024 · 3 comments

Comments

@prplz
Copy link

prplz commented Jan 25, 2024

I was experiencing corruption of the png when using addLine, but not when using addRGB565Line. I noticed they don't share code and they aren't identical, and copying the "good" code from add565 fixed the issue for me even though I didn't look into what the actual changes are: bd26d99.

@bitbank2
Copy link
Owner

Thanks for finding this. I'm super busy on a bunch of other projects. Can you do a pull request?

@prplz
Copy link
Author

prplz commented Jan 26, 2024

Sure! Is it ok if I also make addRGB565Line tail call into addLine to deduplicate the code?

@bitbank2
Copy link
Owner

certainly - thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants