New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentAccountTypeAdapter.writeComments never adds extra comment for SWIFT_ID #7366

Open

thecockatiel opened this issue Jan 30, 2025 · 0 comments

Contributor

thecockatiel commented Jan 30, 2025

From what it seems, the if is incorrectly written and will never be true:

bisq/core/src/main/java/bisq/core/api/model/PaymentAccountTypeAdapter.java

Line 135 in b3f44d2

if (account.hasPaymentMethodWithId("SWIFT_ID")) {

it seems like it should be PaymentMethod.SWIFT_ID instead

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment