Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give front-end and back-end test directories the same name #589

Open
gwarmstrong opened this issue Sep 10, 2019 · 2 comments
Open

give front-end and back-end test directories the same name #589

gwarmstrong opened this issue Sep 10, 2019 · 2 comments

Comments

@gwarmstrong
Copy link
Member

Yeah, we need both. Essentially this file is saying "don't include coverage information for these directories in the total summary"—it was already excluding the tests/ directory (i.e. labcontrol/db/tests/, but it wasn't excluding the test/ directory for the front-end (labcontrol/gui/test/). This change should fix that problem, and the result is that coveralls should now provide a more realistic representation of the code coverage.

...It might also be worth renaming either of the test directories to make them consistent, since having the test directories be named slightly differently is a little bit confusing :)

Originally posted by @fedarko in #585

@gwarmstrong
Copy link
Member Author

To summarize concisely, we should pick a convention for testing, either all tests in directories named test/ ore tests/, but not a mix of both throughout the project.

@fedarko
Copy link
Collaborator

fedarko commented Sep 10, 2019

We'll likely need to update a variety of parts of the code that reference these directory names, including .coveragerc, .travis.yml, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants