Plate-mapper behaving incorrectly. #553
Comments
The above part of this issue was partially resolved with PR #557 |
|
Confirmed that with this fix, when control types ('blank', 'contam', etc.) are cut and pasted into a cell or typed, the control type will appear in the pull-down menu, even if the entry is in mixed or upper case. Confirming w/wetlab that when they cut and paste the blank control type, it is just the keyword 'blank' in arbitrary case. However, I believe the use case where this is an issue is actually when multiple cells have been selected and copied from Excel/Google Sheets and pasted into the plate-mapper. Once we have a solid solution for handling typing/single cell cut and paste versus multi-cell cut and paste, we will need to make sure it can process control types as well. |
Similarly, when a Tube ID is typed or cut and pasted in whole or in part a single cell at a time, the fully qualified Tube ID, with Study ID prepended should appear in the drop-down menu. However, the case where this is still an issue is when multiple cells have been selected from Google Sheets and pasted into the plate-mapper. Obviously, the pull-down menu can't be generated for each cell, and moreover, having multi-cell cut and paste plugin activated currently disables the drop-down menu for multi and single-cell focus (but not typing). I wrote a solution on the server side that, for any cell update (PATCH), checks to see if the cell value begins with the study id and if it's not there, prepend it to the value. However, you can see during the update process that each update happens as that individual cell is updated, and it can take a few seconds before a certain cell is updated and eventually the color changes from red to normal. I think in general, the multi-select cut and paste needs to be made more efficient, and in particular this problem should be solved by getting the set of all valid IDs for this/these studies, and matched during the pasting process. |
|
Testing against the Palmer Rats study should be done once the next release is pushed to RC (maptest.ucsd.edu) for testing, as the data will be there. |
This is an important part of implementing client-side multi-matching (i.e. getting all the IDs needed to perform matching). Pair-programmed with @charles-cowart :)
TODOs: -Better then() failure handling on get_active_samples() -Apply yellow well color (well-indeterminate CSS class IIRC) if multiple matches are possible. -Remove debug console.log() stmts
Wet-lab has an issue with blank cells - it appears when the data is all lower-case and is copied and pasted from google sheets, LabControl can reformat the data as intended. If one or more characters are uppercase, LC will highlight the items in red.
Wet-lab still needs to manually input the Qiita Study ID before the Tube ID for the AGP and Palmer Rats studies. This may be related, hence it has been documented here.
Wet-lab has observed an issue while working with Palmer_Rats_11479_35. When migrating away from the Plate-mapper dialog, entries flagged red usually disappear, while normal entries are saved. During recent use, they have experienced the opposite happening at least on one occasion, as seen in the image.
All three items should be investigated as a whole, since the plate-mapper code is highly interactive. Some items may be duplicated in part from a previous issue.
The text was updated successfully, but these errors were encountered: