Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding existing bilby developers #34

Open
mj-will opened this issue Sep 17, 2024 · 12 comments
Open

Adding existing bilby developers #34

mj-will opened this issue Sep 17, 2024 · 12 comments

Comments

@mj-will
Copy link
Collaborator

mj-will commented Sep 17, 2024

If you're an existing bilby developer that has contributed on GitLab, please add a comment below so we can add your GitHub user to this repo.

@adivijaykumar
Copy link
Collaborator

@adivijaykumar

@cplb
Copy link
Collaborator

cplb commented Sep 17, 2024

@cplb

@mattpitkin
Copy link
Collaborator

@mattpitkin

@asb5468
Copy link
Collaborator

asb5468 commented Sep 17, 2024

@asb5468

@nikhil-sarin
Copy link
Collaborator

nikhil-sarin commented Sep 17, 2024

I contributed with different usernames but can you add @nikhil-sarin ? Or is this restricted to the "approvers"

@cjhaster
Copy link
Collaborator

@cjhaster

@mj-will
Copy link
Collaborator Author

mj-will commented Sep 18, 2024

I contributed with different usernames but can you add @nikhil-sarin ? Or is this restricted to the "approvers"

We're still figuring out some of the details, but we may not actually need to add everyone (outside of admins) since it seems that people don't need to be part of the repo to open PRs or review them.

We may however need them for migrating the issues and PRs over, but we're still figuring out the details for that.

@AlexandreGoettel
Copy link
Collaborator

@AlexandreGoettel

@mattpitkin
Copy link
Collaborator

@nikhil-sarin just to note, if you want any prior contributions to bilby to show up linked to you GitHub account, you can just add the email address(es) that you have git configured for (run git config --get user.email) to you GitHub profile. For example, adding you @ligo.org email.

@nikhil-sarin
Copy link
Collaborator

@nikhil-sarin just to note, if you want any prior contributions to bilby to show up linked to you GitHub account, you can just add the email address(es) that you have git configured for (run git config --get user.email) to you GitHub profile. For example, adding you @ligo.org email.

Thanks @mattpitkin - I just get an error message saying 'email already in use'. The emails were linked to student/staff accounts at Monash that have since been deactivated. I can't verify those email addresses or access them so it feels a bit of a lost cause/more of a hassle than its worth.

@GregoryAshton
Copy link
Collaborator

@GregoryAshton

@dbkeitel
Copy link
Collaborator

@dbkeitel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants