New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object-detector/object-detector/nms.py #22

Open

thomberg1 opened this issue Mar 7, 2018 · 0 comments

thomberg1 commented Mar 7, 2018

for index, detection in enumerate(detections):
        for new_detection in new_detections:
            if overlapping_area(detection, new_detection) > threshold:
                del detections[index]
                break
        else:
            new_detections.append(detection)
            del detections[index]

changes to iterator will not work - nms produces:

detections = [[10, 10, .12, 10, 10], [50, 50, .8,10, 10], [100, 100, 0.9, 10, 10]]
print ("Detections before NMS = {}".format(detections))
print ("Detections after NMS = {}".format(nms(detections)))

Detections before NMS = [[10, 10, 0.12, 10, 10], [50, 50, 0.8, 10, 10], [100, 100, 0.9, 10, 10]]
Detections after NMS = [[100, 100, 0.9, 10, 10], [50, 50, 0.8, 10, 10]]

e.g. change to:

while len(detections) > 0:
    detection = detections.pop()
    for new_detection in new_detections:
        if overlapping_area(detection, new_detection) > threshold:
            break
    else:
        new_detections.append(detection)

detections = [[10, 10, .12, 10, 10], [50, 50, .8,10, 10], [100, 100, 0.9, 10, 10]]
print ("Detections before NMS = {}".format(detections))
print ("Detections after NMS = {}".format(nms(detections)))

Detections before NMS = [[10, 10, 0.12, 10, 10], [50, 50, 0.8, 10, 10], [100, 100, 0.9, 10, 10]]
Detections after NMS = [[100, 100, 0.9, 10, 10], [10, 10, 0.12, 10, 10], [50, 50, 0.8, 10, 10]]

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment