Check Platform.glFoo in headless

[sprunk]

Platform.glHaveGLSL is defined to true, this is incorrect since headless doesn't actually have GLSL:

spring/rts/Lua/LuaConstPlatform.cpp

Line 96 in 34671c0

LuaPushNamedBool(L, "glHaveGLSL", true);

The task is to figure out which entries are incorrect this way, and fix them. I assume that in headless, all the glHaveFoo and glSupportFoo should be false, availableVideoModes should probably be empty, and numDisplays should probably be 0. Double-check this.

Stuff like glVersion probably stays as-is. Perhaps there could be a Platform.isHeadless or Engine.isHeadless as well?

[saurtron]

from github runner:

probably could do glHaveGLSL = glslVersionNum > 0, marked with <--- all the suspicious ones.

can tell its headless easily but all in all ppl probably shouldn't be checking for headless, but for min gl version or similar. still, we could compile isHeadless so ppl can check directly if they need instead of using awkward tests like glslVersionNum == 0, gpuMemorySize == 0 or string.find(glewVesion, "headless").

{
	"availableVideoModes": [],
	"cpuLogicalCores": 4,
	"cpuPhysicalCores": 2,
	"glHaveAMD": false,
	"glHaveGL4": false,
	"glHaveGLSL": true, <---
	"glHaveNVidia": false,
	"glRenderer": "",
	"glSupportClipSpaceControl": false,
	"glSupportDepthBufferBitDepth": 16,
	"glSupportFragDepthLayout": false,
	"glSupportMSAAFrameBuffer": false,
	"glSupportNonPowerOfTwoTex": true, <---
	"glSupportRestartPrimitive": false,
	"glSupportSeamlessCubeMaps": false,
	"glSupportTextureQueryLOD": true, <---
	"glVendor": "",
	"glVersion": "",
	"glVersionShort": "",
	"glewVesion": "spring headless stub GLEW version",
	"glslVersion": "",
	"glslVersionNum": 0,
	"glslVersionShort": "",
	"gpu": "Unknown",
	"gpuMemorySize": 0,
	"gpuVendor": "Unknown",
	"hwConfig": "AMD EPYC 7763 64-Core Processor; 15990MB RAM",
	"macAddrHash": "673757966",
	"numDisplays": 0,
	"osFamily": "Linux",
	"osName": "Linux 6.8.0-1017-azure",
	"osVersion": "#20-Ubuntu SMP Tue Oct 22 03:43:13 UTC 2024 (x86_64)",
	"sdlVersionCompiledMajor": 2,
	"sdlVersionCompiledMinor": 0,
	"sdlVersionCompiledPatch": 8,
	"sdlVersionLinkedMajor": 0,
	"sdlVersionLinkedMinor": 0,
	"sdlVersionLinkedPatch": 0
}

[sprunk]

Good find, though github runner may well in fact have 0 displays (and no general graphical support). Perhaps worth running on a "normal" machine as well.

[saurtron]

from a real computer basically the same thing:

{
	"availableVideoModes": [],
	"cpuLogicalCores": 8,
	"cpuPhysicalCores": 4,
	"glHaveAMD": false,
	"glHaveGL4": false,
	"glHaveGLSL": true,
	"glHaveNVidia": false,
	"glRenderer": "",
	"glSupportClipSpaceControl": false,
	"glSupportDepthBufferBitDepth": 16,
	"glSupportFragDepthLayout": false,
	"glSupportMSAAFrameBuffer": false,
	"glSupportNonPowerOfTwoTex": true,
	"glSupportRestartPrimitive": false,
	"glSupportSeamlessCubeMaps": false,
	"glSupportTextureQueryLOD": true,
	"glVendor": "",
	"glVersion": "",
	"glVersionShort": "",
	"glewVersion": "spring headless stub GLEW version",
	"glslVersion": "",
	"glslVersionNum": 0,
	"glslVersionShort": "",
	"gpu": "Unknown",
	"gpuMemorySize": 0,
	"gpuVendor": "Unknown",
	"numDisplays": 0,
	"osFamily": "Linux",
	"sdlVersionCompiledMajor": 2,
	"sdlVersionCompiledMinor": 0,
	"sdlVersionCompiledPatch": 8,
	"sdlVersionLinkedMajor": 0,
	"sdlVersionLinkedMinor": 0,
	"sdlVersionLinkedPatch": 0
}