You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@isabarros raised a very valid point during our discussion in the PR #93. To expand pyp5js configuration and also to be able to unit test the base SKETCHBOOK_DIR creation, we should change the existing pytest.config module to export a lazy-load object instead of giving direct access to its configuration constants. Django's settings should be the main guide as an approach to address that. The ideal import to use pyp5js configs would be:
I think it's only worthwhile to work on this issue after #93 is merged into develop. This is because this new conf object implicates in a few code changes that would be better to do with a better test coverage for the web application.
The text was updated successfully, but these errors were encountered:
@isabarros raised a very valid point during our discussion in the PR #93. To expand pyp5js configuration and also to be able to unit test the base
SKETCHBOOK_DIR
creation, we should change the existingpytest.config
module to export a lazy-load object instead of giving direct access to its configuration constants. Django's settings should be the main guide as an approach to address that. The ideal import to use pyp5js configs would be:I think it's only worthwhile to work on this issue after #93 is merged into develop. This is because this new
conf
object implicates in a few code changes that would be better to do with a better test coverage for the web application.The text was updated successfully, but these errors were encountered: