Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Allow passing docker run arguments in host_bento #4031

Open
mkmenta opened this issue Jul 10, 2023 · 2 comments
Open

feature: Allow passing docker run arguments in host_bento #4031

mkmenta opened this issue Jul 10, 2023 · 2 comments
Labels
enhancement Enhancement proposals

Comments

@mkmenta
Copy link

mkmenta commented Jul 10, 2023

Feature request

Hi!

I think it would be very useful to have the possibility to pass arguments in the docker run of host_bento.
That is, to have the possibility to pass command arguments in run_bento_server_container here.

Right now the possibility of passing arguments is only supported for the "containerize" phase with the container_mode_options. It would be nice to have something similar but for the docker run.

Motivation

This feature would be especially useful to pass environment variables with secrets during the run of the service container.

Other

I wouldn't mind helping with the implementation if you also think that it is an important feature to add.

@mkmenta mkmenta added the enhancement Enhancement proposals label Jul 10, 2023
@aarnphm
Copy link
Contributor

aarnphm commented Jul 10, 2023

we are yet to decide on how we want to provide a testing API for bentoml atm. We had some discussion in the past internally, but currently this is within our backlog. It would be great if you can provide a usecase for using this, since host_bento is currently still considered as internal API

@mkmenta
Copy link
Author

mkmenta commented Jul 11, 2023

I see... I began using host_bento because I saw it in the repo examples and I found it very useful.

In my case, I am facing a situation where I need to add some secrets and credentials as environment variables during the docker run of the service container. I need to run some requests to an external service as a pre-processing before running the model inference. However, I can't do that right now in host_bento because it does not allow passing extra arguments to the docker run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement proposals
Projects
None yet
Development

No branches or pull requests

2 participants