Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(570): refactoring silviculture search #571

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Jan 24, 2025

Description

Refactor of the silviculture search screen including a new visual for the search screen and a refactored codebase.

Fixes # 570

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Initial refactor search screen
@paulushcgcj paulushcgcj linked an issue Jan 24, 2025 that may be closed by this pull request
3 tasks
@paulushcgcj paulushcgcj added bug Something isn't working enhancement New feature or request javascript Pull requests that update Javascript code labels Jan 24, 2025
@paulushcgcj
Copy link
Contributor Author

@craigyu feel free to apply the breakpoint context you created on #582 here to fix the visual issues.

Most of the functionalities are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEV TASK]: Refactor Silviculture search
2 participants