Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

//tools/rust_analyzer:gen_rust_project does not build all required targets #3170

Open
martingms opened this issue Jan 8, 2025 · 5 comments · May be fixed by #3192
Open

//tools/rust_analyzer:gen_rust_project does not build all required targets #3170

martingms opened this issue Jan 8, 2025 · 5 comments · May be fixed by #3192

Comments

@martingms
Copy link
Contributor

When using bazel's --disk_cache (and possibly in other remote cache situations?) gen_rust_project can generate rust-project.json files that contains paths in "proc_macro_dylib_path" that are invalid at the time of generation.

One easy to reproduce example as long as cargo crates with proc-macros are used in the project: Enable --disk_cache, run a full build to populate the cache, bazel clean, run a new full build for good measure, run //tools/rust_analyzer:gen_rust_project.
"proc_macro_dylib_path" for e.g. clap_derive will now be something like. /home/<...>/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/rules_rust++crate+crates__clap_derive-4.5.18/libclap_derive-2275298359.so which has not been rebuilt and therefore does not exist.

I've not found a way to force it to be built manually either in this case, where I depend on the clap_derive crate transitively, so it's not available at @crates//:clap_derive or similar.
@martingms
Copy link
Contributor Author

Took a quick look. gen_rust_project shells out to bazel build <... aspect stuff ...> @//... by default, but takes targets as an argument. This makes it possible to generate all crates at least by running ... gen_rust_project -- @//... @crates//... instead, but that still doesn't help w.r.t. transitive deps that are not visible of course...

@ajwerner
Copy link
Contributor

My workaround for this has been to separately in vscode as a startup task to build everything. It's not beautiful.

@martingms
Copy link
Contributor Author

My workaround for this has been to separately in vscode as a startup task to build everything. It's not beautiful.

I don't mind ugly as long as it works.. How do you build the transitive deps though?

@hauserx
Copy link
Contributor

hauserx commented Jan 20, 2025

@martingms does rebuilding with --remote_download_all help here? By default bazel 7 will not download intermediate artifacts if not needed, but this option forces it to do so.

@martingms
Copy link
Contributor Author

martingms commented Jan 21, 2025 •
edited
Loading

@hauserx that seems to do it, thanks! Perhaps this flag should be added to the build-command that gen_rust_project issues? Opened a PR to that effect if you think this is a good idea.

martingms added a commit to martingms/rules_rust that referenced this issue Jan 21, 2025
@martingms
Use --remote_download_all when building rust_analyzer_crate_specs
f66eb78 
This fixes bazelbuild#3170
@martingms martingms linked a pull request Jan 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use --remote_download_all when building rust_analyzer_crate_specs martingms/rules_rust
3 participants
@martingms @ajwerner @hauserx