From 9308dd129922e766ac14925c65945d4b618ea798 Mon Sep 17 00:00:00 2001 From: Tony Aiuto Date: Fri, 20 Sep 2024 11:43:27 -0400 Subject: [PATCH] Update comments about cfg=exec on license() Provide guidance for how this changes in Bazel 8. To optain the best results, users of Bazel 8 should vendor in rules_license and remove cfg=exec locally. --- rules/license.bzl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/rules/license.bzl b/rules/license.bzl index a5c0379..16d38ad 100644 --- a/rules/license.bzl +++ b/rules/license.bzl @@ -42,7 +42,12 @@ _license = rule( " should be listed here. If the user can choose a single one" + " of many, then only list one here.", providers = [LicenseKindInfo], - # This should be the null configuration, not the exec. + # Bazel 8+ users: In Bazel 8, the targets for package_metadata are + # always in a null configuration. This reflects the fact that they + # are non-configurable and keeps the node for a license in a single + # configuration, no matter what physical platforms you are building + # for. + # TODO: (after bazel 8.0 is mainstream): Remove this line. cfg = "exec", ), "copyright_notice": attr.string(