Shift+scroll sample doesn't jump over categories for Sample, Loop, User

[vananasun]

Not sure if this is intentional. I have been renaming the category names for my sample pack and encountered this issue.
Only happens on these categories and it is annoying!
Sample
Loop
User

[bangcorrupt]

I think this is the same issue as #13. I haven't looked into it yet, but it's probably because I changed the names of some categories.

[vananasun]

I think this is the same issue as #13. I haven't looked into it yet, but it's probably because I changed the names of some categories.

That's not the reason. I changed the name of every category in a hex editor and it only happens with Phrase,Loop,User. I think it may have to do with the fact that these categories are geared towards slices?

[bangcorrupt]

If you edit the category names in Hacktribe to match the factory sampler firmware, does it skip over them correctly?

It could be related to samples being in slots where they're not expected.

[vananasun]

I tested it and figured out that it really is Sample,Loop,User categories with this problem. I reckon this was done on purpose to slowly scroll past slices, but it is kind of annoying since you cannot rely on shift+scroll to select an entire different category anymore.

[bangcorrupt]

I think you're right that it's a feature and I agree that it's annoying. I noticed that some categories are skipped fully when scrolling backwards, but not when scrolling forwards. That's definitely a bug. I haven't checked if this happens with the factory firmware or if I introduced it in Hacktribe. #13 is a separate issue.

Fixed in 704dd7f.

I changed a conditional branch to always branch, skipping the code that treats those categories differently. I only tested briefly, but skipping those categories appears to work and nothing appears to be broken.

Thank you for sponsoring Hacktribe! 😃

I added the skip-osc-cat branch to the Hacktribe Tutorial for easy testing.

This is now in the main branch.