From 83553cc8fa18113dcaf0b2aa51e3e48c63a50f9c Mon Sep 17 00:00:00 2001
From: baileyspraggins <baileyspraggins@me.com>
Date: Mon, 17 Jul 2023 15:37:12 -0500
Subject: [PATCH] PR Comments addressed
---
contracts/BaseRateProviderFactory.sol | 10 ++++------
contracts/ChainlinkRateProviderFactory.sol | 1 -
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/contracts/BaseRateProviderFactory.sol b/contracts/BaseRateProviderFactory.sol
index c419e0d..30be06a 100644
--- a/contracts/BaseRateProviderFactory.sol
+++ b/contracts/BaseRateProviderFactory.sol
@@ -17,15 +17,13 @@ pragma solidity ^0.8.0;
import "./interfaces/IBaseRateProviderFactory.sol";
/**
- * @title Chainlink Rate Provider Factory
- * @notice Factory for creating ChainlinkRateProviders
- * @dev This contract is used to create ChainlinkRateProvider contracts.
- * RateProviders created by this factory are to be used in environments
- * where the Chainlink registry is not available.
+ * @title Base Rate Provider Factory
+ * @notice Base Factory for creating RateProviders
+ * @dev This is a base contract for building factories that create RateProviders.
*/
contract BaseRateProviderFactory is IBaseRateProviderFactory {
// Mapping of rate providers created by this factory.
- mapping(address => bool) internal _factoryCreatedRateProviders;
+ mapping(address => bool) private _factoryCreatedRateProviders;
event RateProviderCreated(address indexed rateProvider);
diff --git a/contracts/ChainlinkRateProviderFactory.sol b/contracts/ChainlinkRateProviderFactory.sol
index 33f7dba..4e6a5ec 100644
--- a/contracts/ChainlinkRateProviderFactory.sol
+++ b/contracts/ChainlinkRateProviderFactory.sol
@@ -34,7 +34,6 @@ contract ChainlinkRateProviderFactory is BaseRateProviderFactory {
function create(AggregatorV3Interface feed) external returns (ChainlinkRateProvider) {
ChainlinkRateProvider rateProvider = new ChainlinkRateProvider(feed);
_onCreate(address(rateProvider));
-
return rateProvider;
}
}