-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to dry run #6
Comments
👍 I certainly understand why you'd want that but not sure how it would work exactly? The output is just a change in the files so you would just do a git reset to go back and git diff to view? Unless you have something of an idea for it? |
I was thinking, the output would actually be like a git diff. The only change is that it applies no changes. There isn't any special case I had in mind. |
If you are already using git and run |
I do agree with you. It's not really necessary |
Unless we think a better default is --dry and to use |
Well. That does sound interesting. I think this is something that needs to be discussed with more ppl. Some might prefer to go ahead with the change and some (like me) might want the dry run first before accepting changes. |
Yes please make the default safe. |
Separately, having a dry run option that exits zero when no changes are made is always useful for CIs, to avoid having to manually check and reset a git diff. |
I guess it depends what do you mean by safe? It modifies files in the git repo which can be reset. What's the usecase for running in CI other than if we figure out how to make it as a service to auto PR some repos? |
I'm not sure off the top of my head :-) but in general, every tool I've ever used that modifies files, I've ended up needing a way to validate that the command has been ran in CI. |
Can I take this up? @hzoo |
Sure @kedromelon. Will be creating a PR by end of this week. |
Really useful tool! I think there should be a dry run option just to see what changes the tool will generate before applying them.
I would like to contribute on this, if you do consider such an option
Thanks,
Faizaan.
The text was updated successfully, but these errors were encountered: