Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent package name of "transport" #564

Open
ryan-ju opened this issue Jan 21, 2025 · 2 comments
Open

Inconsistent package name of "transport" #564

ryan-ju opened this issue Jan 21, 2025 · 2 comments

Comments

@ryan-ju
Copy link

ryan-ju commented Jan 21, 2025

https://github.com/aws/smithy-go/blob/main/endpoints/endpoint.go

The directory is endpoint but the package is transport. This violates Go's naming conventions.

@lucix-aws
Copy link
Contributor

I noticed this recently. I'm not sure what we can do about it without incurring a compiler break. We'll probably just have to spawn a new package and mark all the APIs here as deprecated, but that's a non-trivial lift to getting usage of this migrated over in generated SDKs.

@lucix-aws
Copy link
Contributor

In fact, I don't even think we can address that, because it's going to break the signature of APIs generated in said clients (EndpointResolverV2 is typed to return this).

Leaving open for the record, but I don't see a future where this is addressed, at least in the downstream Go SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants