Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support endpoint configuration via env and shared config #4942

Closed
2 tasks
adrianlungu opened this issue Aug 8, 2023 · 2 comments
Closed
2 tasks

Support endpoint configuration via env and shared config #4942

adrianlungu opened this issue Aug 8, 2023 · 2 comments
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@adrianlungu
Copy link

Describe the feature

Given that the AWS-CLI has received support for endpoint configuration via AWS_ENDPOINT_URL env vars, or the shared config file, as detailed here: https://aws.amazon.com/blogs/developer/new-improved-flexibility-when-configuring-endpoint-urls-with-the-aws-sdks-and-tools/

It would be nice if the Go AWS SDK also supported this to be able to configure the AWS endpoint url automatically as done with other variables, without having to explicitly specify it in code.

Use Case

Configuring the AWS session via environment variables or the shared configuration file without having to maintain the variable in multiple places to pass it to code via a WithEndpoint func.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.44.318

Environment details (Version of Go (go version)? OS name and version, etc.)

go1.20.5, MacOS Ventura 13.5
@adrianlungu adrianlungu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 8, 2023
@lucix-aws lucix-aws added queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Aug 8, 2023
@lucix-aws lucix-aws changed the title Support for AWS_ENDPOINT_URL Support endpoint configuration via env and shared config Aug 8, 2023
@lucix-aws
Copy link
Contributor

(same as aws-sdk-go-v2/#2226)

@ewbankkit ewbankkit mentioned this issue Aug 9, 2023
Closed
@lucix-aws lucix-aws assigned lucix-aws and isaiahvita and unassigned lucix-aws Sep 12, 2023
@lucix-aws lucix-aws added p1 This is a high priority issue and removed queued This issues is on the AWS team's backlog labels Sep 21, 2023
sdelano added a commit to sdelano/vals that referenced this issue Oct 19, 2023
@sdelano
support AWS_ENDPOINT_URL configuration
8d3d6cb 
the AWS SDK and CLI (currently only in Python) allows for
configuration of the AWS endpoint URL via the `AWS_ENDPOINT_URL`
environment variable [1].

the Golang AWS SDK does not currently support this, but according to
GitHub issues, parity is on the way [2].

this change allows for a temporary workaround (it took two years for
this support to make it to the Python SDK [3]) that allows `vals` to
pick up the `AWS_ENDPOINT_URL` environment variable and configure the
session accordingly.

this allows for testing with non-AWS infrastructure like Localstack
and Moto, and could even open the door for more comprehensive
integration tests of the AWS functionality in this project without the
need for using real AWS infrastructure.

[1]: https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html
[2]: aws/aws-sdk-go#4942
[3]: boto/boto3#2746
@sdelano sdelano mentioned this issue Oct 19, 2023
Merged
sdelano added a commit to sdelano/vals that referenced this issue Oct 19, 2023
@sdelano
support AWS_ENDPOINT_URL configuration
ba42146 
the AWS SDK and CLI (currently only in Python) allows for
configuration of the AWS endpoint URL via the `AWS_ENDPOINT_URL`
environment variable [1].

the Golang AWS SDK does not currently support this, but according to
GitHub issues, parity is on the way [2].

this change allows for a temporary workaround (it took two years for
this support to make it to the Python SDK [3]) that allows `vals` to
pick up the `AWS_ENDPOINT_URL` environment variable and configure the
session accordingly.

this allows for testing with non-AWS infrastructure like Localstack
and Moto, and could even open the door for more comprehensive
integration tests of the AWS functionality in this project without the
need for using real AWS infrastructure.

[1]: https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html
[2]: aws/aws-sdk-go#4942
[3]: boto/boto3#2746

Signed-off-by: Stephen Delano <[email protected]>
@lucix-aws lucix-aws added p3 This is a minor priority issue and removed p1 This is a high priority issue labels Oct 23, 2023
mumoshu pushed a commit to helmfile/vals that referenced this issue Dec 1, 2023
@sdelano
support AWS_ENDPOINT_URL configuration (#177)
3abfd38 
the AWS SDK and CLI (currently only in Python) allows for
configuration of the AWS endpoint URL via the `AWS_ENDPOINT_URL`
environment variable [1].

the Golang AWS SDK does not currently support this, but according to
GitHub issues, parity is on the way [2].

this change allows for a temporary workaround (it took two years for
this support to make it to the Python SDK [3]) that allows `vals` to
pick up the `AWS_ENDPOINT_URL` environment variable and configure the
session accordingly.

this allows for testing with non-AWS infrastructure like Localstack
and Moto, and could even open the door for more comprehensive
integration tests of the AWS functionality in this project without the
need for using real AWS infrastructure.

[1]: https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html
[2]: aws/aws-sdk-go#4942
[3]: boto/boto3#2746

Signed-off-by: Stephen Delano <[email protected]>
@lucix-aws lucix-aws closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrianlungu @isaiahvita @lucix-aws