Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user agent app tag in IMDS client #2943

Open
2 tasks
croepha opened this issue Jan 6, 2025 · 0 comments
Open
2 tasks

Support user agent app tag in IMDS client #2943

croepha opened this issue Jan 6, 2025 · 0 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@croepha
Copy link

croepha commented Jan 6, 2025

Describe the feature

I would like to be able to add some application specific string to the user agent header sent with http requests to the IMDS service

Use Case

This would be very helpful in debugging which application in an ec2 instance is making a request when viewing multiple requests in a packet capture. This could also be used to enhance auditing of IMDS requests

Proposed Solution

it seems that if you load a config with an option like config.WithAppID("myCoolApp") it does not actually effect the IMDS client. I think that you should make that config also apply to the IMDS client which would make the behavior the same as the majority of other clients in this package

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

$ cat go.mod | grep aws
 github.com/aws/aws-sdk-go-v2 v1.32.6
 github.com/aws/aws-sdk-go-v2/config v1.28.6
 github.com/aws/aws-sdk-go-v2/credentials v1.17.47
 github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.21
 github.com/aws/aws-sdk-go-v2/service/firehose v1.35.2
 github.com/aws/aws-sdk-go-v2/service/kinesis v1.32.7
 github.com/aws/smithy-go v1.22.1
 github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.7 // indirect
 github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.25 // indirect
 github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.25 // indirect
 github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
 github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.1 // indirect
 github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.6 // indirect
 github.com/aws/aws-sdk-go-v2/service/sso v1.24.7 // indirect
 github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.6 // indirect
 github.com/aws/aws-sdk-go-v2/service/sts v1.33.2 // indirect

Go version used

go version go1.23.2 linux/amd64
@croepha croepha added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2025
@lucix-aws lucix-aws added p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

2 participants