-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-elasticloadbalancingv2: ApplicationListener open prop does not account for LB type DUAL_STACK_WITHOUT_PUBLIC_IPV4 #32197
Comments
Hi @clareliguori , thanks for reporting this. The issue is reproducible with given code snippet - const albv2 = new patterns.ApplicationLoadBalancedFargateService(this, 'MyFargateService', {
taskImageOptions: {
image: ecs.ContainerImage.fromRegistry("amazon/amazon-ecs-sample"),
},
cluster: clusterv2,
desiredCount: 1,
publicLoadBalancer: true,
domainName: 'mydomain.com',
domainZone: route53.HostedZone.fromLookup(this, 'MyHostedZone', { domainName: 'mydomain.com' }),
protocol: elbv2.ApplicationProtocol.HTTPS,
redirectHTTP: true,
sslPolicy: elbv2.SslPolicy.RECOMMENDED_TLS
}); generated template - Appreciate your PR contribution! Thanks. |
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
PR was reverted, hence, re-opening |
Describe the bug
The automatically generated security group ingress rules for an ALB are incorrect when 1) an ApplicationLoadBalancer IP address type is set to
DUAL_STACK_WITHOUT_PUBLIC_IPV4
and 2) a listener on the LB is set to allow anyone to connect to the load balancer on the listener portopen: true
. The generated rules only allow IPV4 inbound traffic and no IPV6 inbound traffic, which effectively allows no external traffic.Support for DUAL_STACK_WITHOUT_PUBLIC_IPV4 was added in CDK v2.159.0, but missed this change.
Regression Issue
Last Known Working CDK Version
No response
Expected Behavior
Example security group ingress rules:
Current Behavior
Example security group ingress rules:
Reproduction Steps
I'm using the ECS patterns module, which automatically generated the load balancer:
Possible Solution
I have what I believe is a fix, but I still need to update tests and validate:
Additional Information/Context
No response
CDK CLI Version
2.164.1
Framework Version
No response
Node.js Version
v20.18.0
OS
Linux
Language
TypeScript
Language Version
5.6.2
Other information
No response
The text was updated successfully, but these errors were encountered: