Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch: aws-cdk-go: case-insensitive file name collision with CfnJobDefinition_EFSVolumeConfigurationProperty.go #32743

Closed
1 task done
fabiolanfranchi opened this issue Jan 6, 2025 · 4 comments · Fixed by #32755
Labels
@aws-cdk/aws-batch Related to AWS Batch bug This issue is a bug. management/tracking Issues that track a subject or multiple issues p0 potential-regression Marking this issue as a potential regression to be checked by team member

Comments

@fabiolanfranchi
Copy link

fabiolanfranchi commented Jan 6, 2025

Please add your +1 👍 to let us know you have encountered this

Status: IN-PROGRESS

Overview:

Due to some changes in AWS Batch service CFN schema, and renaming in some types, the generated L1 classes for these types have conflicts in names that will cause issues in case insensitive systems.

Complete Error Message:

Go reports a case-insensitive file name collision when I run `go get github.com/aws/aws-cdk-go/awscdk/[email protected]`. The conflict is caused by [awsbatch/CfnJobDefinition_EFSVolumeConfigurationProperty.go](https://github.com/aws/aws-cdk-go/blob/awscdk/v2.174.0/awscdk/awsbatch/CfnJobDefinition_EFSVolumeConfigurationProperty.go) and [awsbatch/CfnJobDefinition_EfsVolumeConfigurationProperty.go](https://github.com/aws/aws-cdk-go/blob/awscdk/v2.174.0/awscdk/awsbatch/CfnJobDefinition_EfsVolumeConfigurationProperty.go).

Workaround:

Revert aws-cdk-lib to version 2.173.4 or less.

Solution:

The team will patch a new release (2.174.1) that contains a fix for this issue.


Original Issue

Describe the bug

I use aws-cdk-go and I'm trying to upgrade from v2.173.4 to v2.174.0 on macOS with the default case-insensitive file system (APFS).

Go reports a case-insensitive file name collision when I run go get github.com/aws/aws-cdk-go/awscdk/[email protected]. The conflict is caused by awsbatch/CfnJobDefinition_EFSVolumeConfigurationProperty.go and awsbatch/CfnJobDefinition_EfsVolumeConfigurationProperty.go.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

2.173.4

Expected Behavior

go get github.com/aws/aws-cdk-go/awscdk/[email protected] should succeed on case-insensitive file systems.

Current Behavior

The command fails and the dependency is not updated in go.mod.

% go get github.com/aws/aws-cdk-go/awscdk/[email protected]
go: downloading github.com/aws/aws-cdk-go/awscdk/v2 v2.174.0
go: github.com/aws/aws-cdk-go/awscdk/[email protected]: create zip: awsbatch/CfnJobDefinition_EfsVolumeConfigurationProperty.go: case-insensitive file name collision: "awsbatch/CfnJobDefinition_EFSVolumeConfigurationProperty.go" and "awsbatch/CfnJobDefinition_EfsVolumeConfigurationProperty.go"

Reproduction Steps

On macOS with case-insensitive APFS run go get github.com/aws/aws-cdk-go/awscdk/[email protected].

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.174.0 (build 9604329)

Framework Version

No response

Node.js Version

22.12.0

OS

macOS 15.2

Language

Go

Language Version

1.23.4

Other information

No response

@fabiolanfranchi fabiolanfranchi added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2025
@github-actions github-actions bot added @aws-cdk/aws-batch Related to AWS Batch potential-regression Marking this issue as a potential regression to be checked by team member labels Jan 6, 2025
@krokoko
Copy link

krokoko commented Jan 6, 2025

@ashishdhingra ashishdhingra self-assigned this Jan 6, 2025
@ashishdhingra ashishdhingra added p1 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2025
@ashishdhingra
Copy link
Contributor

Looks like in CDK documentation as well, we have definition for 2 interfaces:

Easily reproducible using below commands (in a new directory):

This gives error:

go: github.com/aws/aws-cdk-go/awscdk/[email protected]: verifying go.mod: github.com/aws/aws-cdk-go/awscdk/[email protected]/go.mod: reading https://sum.golang.org/lookup/github.com/aws/aws-cdk-go/awscdk/[email protected]: 404 Not Found
	server response: not found: create zip: awsbatch/CfnJobDefinition_EfsVolumeConfigurationProperty.go: case-insensitive file name collision: "awsbatch/CfnJobDefinition_EFSVolumeConfigurationProperty.go" and "awsbatch/CfnJobDefinition_EfsVolumeConfigurationProperty.go"

@ashishdhingra ashishdhingra added p0 and removed p1 investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 6, 2025
@ashishdhingra ashishdhingra removed their assignment Jan 6, 2025
@moelasmar moelasmar added management/tracking Issues that track a subject or multiple issues and removed potential-regression Marking this issue as a potential regression to be checked by team member labels Jan 6, 2025
@github-actions github-actions bot added the potential-regression Marking this issue as a potential regression to be checked by team member label Jan 6, 2025
@moelasmar moelasmar pinned this issue Jan 6, 2025
@moelasmar
Copy link
Contributor

new CDK lib got released (V2.174.1), and the aws-cdk-go library looks good.

Copy link

github-actions bot commented Jan 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-batch Related to AWS Batch bug This issue is a bug. management/tracking Issues that track a subject or multiple issues p0 potential-regression Marking this issue as a potential regression to be checked by team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants