Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few suggested changes/corrections #28

Open
ghost opened this issue Dec 2, 2021 · 1 comment
Open

Few suggested changes/corrections #28

ghost opened this issue Dec 2, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Dec 2, 2021

1- Instructions in README.md and Jupyter Notebooks. The aws configure command is only required to set the region. Adding the credentials will override the temporary credentials from the role attached to the EC2 instance.

2- In the Cloudformation the default value for the KeyName should be removed.

3- In the Jupyter Notebook, "Notebook Parameter" the string "PLEASE ENTER YOUR DEVICE ID" may confuse the user to enter the device ID there (replacing the text) instead of the previous line.

4- Instructions in the README.md. It would be nice to note that this test utils will require a correct device id for the deployment part. So for customer who does not own a device can try all cells before the deployment cell by using any fake device id.

@shimomut
Copy link
Contributor

shimomut commented Dec 2, 2021

These are all great/useful feedback. Thank you Mohsen.
Let us discuss how to improve these points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant