Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve autoware_testing #389

Closed
2 of 5 tasks
KeisukeShima opened this issue Feb 16, 2022 · 1 comment
Closed
2 of 5 tasks

Improve autoware_testing #389

KeisukeShima opened this issue Feb 16, 2022 · 1 comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:good-first-issue Suitable for newcomers. type:new-feature New functionalities or additions, feature requests.

Comments

@KeisukeShima
Copy link
Contributor

KeisukeShima commented Feb 16, 2022

Motivation

autoware_testing provides basic tests that can be used in common for all packages.
However, the current implementation is only a smoke_test, and what can be checked with this test is limited.
I read an issue on Autoware.Auto about the design of autoware_testing (link) and thought it could be improved.
Specifically, it solves the smoke_test problem and introduces a new interface test. This way, node activation and interface checking can be added to all packages with less effort.

Action Items

Smoke test

Interface test

References

autowarefoundation/autoware-documentation#2 (comment)
https://gitlab.com/autowarefoundation/autoware.auto/AutowareAuto/-/issues/951

@KeisukeShima KeisukeShima self-assigned this Feb 16, 2022
mitsudome-r added a commit to mitsudome-r/autoware.universe that referenced this issue Mar 1, 2022
* release v0.4.0

* add control mode status (autowarefoundation#709)

Signed-off-by: Yamato Ando <[email protected]>

* Change localization diag namespace (autowarefoundation#718)

* Change default value of output_diagnostics_topic

Signed-off-by: Kenji Miyake <[email protected]>

* Remove localization_diagnostic.js from web_controller

Signed-off-by: Kenji Miyake <[email protected]>

* Integrate localization diag to diagnostic_aggregator

Signed-off-by: Kenji Miyake <[email protected]>

* Delete old and unused publisher

Signed-off-by: Kenji Miyake <[email protected]>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* add sample ros2 packages

Signed-off-by: mitsudome-r <[email protected]>

* remove ROS1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit 741214959ba02ec8650c62538581d9df9116eef8.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Port web controller (autowarefoundation#235)

* [autoware_web_controller] intial port to ROS2

Signed-off-by: mitsudome-r <[email protected]>

* add missing dependencies

Signed-off-by: mitsudome-r <[email protected]>

* remove dependency to ament_cmake_auto and depend on ament_cmake

Signed-off-by: mitsudome-r <[email protected]>

* [autoware_web_controller] add messages to exec_depend

Signed-off-by: mitsudome-r <[email protected]>

* [autoware_web_controller] moved files in www into autoware_web_controller directory

Signed-off-by: mitsudome-r <[email protected]>

* Ros2 v0.8.0 engage (autowarefoundation#342)

* [autoware_vehicle_msgs]: Add engage message

Signed-off-by: wep21 <[email protected]>

* [as]: Update message

Signed-off-by: wep21 <[email protected]>

* [awapi_awiv_adapter]: Update message

Signed-off-by: wep21 <[email protected]>

* [web_controller]: Update message

Signed-off-by: wep21 <[email protected]>

* [vehicle_cmd_gate]: Update message

Signed-off-by: wep21 <[email protected]>

* [autoware_state_monitor]: Update message

Signed-off-by: wep21 <[email protected]>

* [autoware_control_msgs]: Remove EngageMode message

Signed-off-by: wep21 <[email protected]>

* [simple_planning_simulator]: Update message

Signed-off-by: wep21 <[email protected]>

* Fix autoware web controller (autowarefoundation#389)

* fix message types

Signed-off-by: mitsudome-r <[email protected]>

* fix subscriber for autoware_engage

Signed-off-by: mitsudome-r <[email protected]>

* fix vehicle_engage.js

Signed-off-by: mitsudome-r <[email protected]>

* fix function syntax for vehicle_engage.js

Signed-off-by: mitsudome-r <[email protected]>

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <[email protected]>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <[email protected]>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <[email protected]>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: pre-commit <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Apply format

Signed-off-by: Kenji Miyake <[email protected]>

* Improve avoidance algorithm in behavior_path_planner (autowarefoundation#2127)

* add debug comment

Signed-off-by: Takamasa Horibe <[email protected]>

* use same clock and logger

Signed-off-by: Takamasa Horibe <[email protected]>

* update

Signed-off-by: Takamasa Horibe <[email protected]>

* remove Frenet struct

Signed-off-by: Takamasa Horibe <[email protected]>

* update

Signed-off-by: Takamasa Horibe <[email protected]>

* change param

Signed-off-by: Takamasa Horibe <[email protected]>

* Correspond exactly to the modified and raw shift points.

Signed-off-by: Takamasa Horibe <[email protected]>

* separate structure file

Signed-off-by: Takamasa Horibe <[email protected]>

* update

Signed-off-by: Takamasa Horibe <[email protected]>

* fix return shift calculation

Signed-off-by: TakaHoribe <[email protected]>

* add index info on path marker

Signed-off-by: Takamasa Horibe <[email protected]>

* update returnSHift func

Signed-off-by: TakaHoribe <[email protected]>

* update param

Signed-off-by: TakaHoribe <[email protected]>

* update findNewShiftPoiint logic by using linear shifter

Signed-off-by: TakaHoribe <[email protected]>

* fix return distance calculation

Signed-off-by: TakaHoribe <[email protected]>

* fix return shift for steep shape

Signed-off-by: TakaHoribe <[email protected]>

* fix for return shift after approval

Signed-off-by: TakaHoribe <[email protected]>

* re-fix for return shift after approval

Signed-off-by: TakaHoribe <[email protected]>

* re-re-fix for return shift after approval

Signed-off-by: TakaHoribe <[email protected]>

* add same object_id shift for parent_ids even if it is not overwrapped.

Signed-off-by: TakaHoribe <[email protected]>

* fix clock for approval_handler

Signed-off-by: Takamasa Horibe <[email protected]>

* fix bug: extra_return_shift is not registered

Signed-off-by: Takamasa Horibe <[email protected]>

* update
 - update logic of unique check for registered shift
 - update addReturnShift func to support for opposite obstacle case
 - disable trimSmallShift

Signed-off-by: Takamasa Horibe <[email protected]>

* use relative shift for avoid start point

Signed-off-by: Takamasa Horibe <[email protected]>

* update path_shifter: use end_point shift for relative shift calculation so that the desired shift length is set at shift_point's end_idx (before, it was set at the end point of the path)

Signed-off-by: Takamasa Horibe <[email protected]>

* update: select existing shift point that will be removed before adding a new one

Signed-off-by: Takamasa Horibe <[email protected]>

* fix path_shifter: current_shift for linear shift

Signed-off-by: Takamasa Horibe <[email protected]>

* update
 - add ignore over-jerk shift function
 - improve debug print

Signed-off-by: Takamasa Horibe <[email protected]>

* update
 - add control flag for debug print
 - add control flag for debug marker

Signed-off-by: Takamasa Horibe <[email protected]>

* TMP: add sparse resampling to reduce computational cost

Signed-off-by: Takamasa Horibe <[email protected]>

* update parameter: min_nominal_avoidance_speed 3.0 -> 5.0

Signed-off-by: Takamasa Horibe <[email protected]>

* cosmetic change
 - move some debug functions to debug.cpp
 - remove temporal debug comment
 - remove unused params
 - parametrize some values
 - align function decleration order

Signed-off-by: TakaHoribe <[email protected]>

* add empty avoidance design

Signed-off-by: TakaHoribe <[email protected]>

* applly format

Signed-off-by: TakaHoribe <[email protected]>

* fix typo

Signed-off-by: TakaHoribe <[email protected]>

* fix design.md directory

Signed-off-by: Takamasa Horibe <[email protected]>

* change variable nale sudden, tight -> sharp

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused param

Signed-off-by: Takamasa Horibe <[email protected]>

* fix default value

Signed-off-by: Takamasa Horibe <[email protected]>

* add design

Signed-off-by: Takamasa Horibe <[email protected]>

* move some functions to util

Signed-off-by: TakaHoribe <[email protected]>

* fix design typo

Signed-off-by: TakaHoribe <[email protected]>

* remove temporal mutable & adjust function name

Signed-off-by: TakaHoribe <[email protected]>

* parametrize some hard-coded params

Signed-off-by: TakaHoribe <[email protected]>

* follow ament_uncrustify & cpplint

Signed-off-by: TakaHoribe <[email protected]>

* fix parent_id inheritance bug

Signed-off-by: TakaHoribe <[email protected]>

* back to experiment config

Signed-off-by: TakaHoribe <[email protected]>

* update trim filter: trimSharpReturn

Signed-off-by: TakaHoribe <[email protected]>

* add lost-detection compensator

Signed-off-by: TakaHoribe <[email protected]>

* resolve todo for empty path

Signed-off-by: TakaHoribe <[email protected]>

* change param: set false for debug publisher

Signed-off-by: TakaHoribe <[email protected]>

* update debug comment

Signed-off-by: TakaHoribe <[email protected]>

* remove unused debug print

Signed-off-by: TakaHoribe <[email protected]>

* update default param

Signed-off-by: Takamasa Horibe <[email protected]>

* use closest footpoint from ego for avoidance point

Signed-off-by: Takamasa Horibe <[email protected]>

* cosmetic change

Signed-off-by: Takamasa Horibe <[email protected]>

* fix format

Signed-off-by: Takamasa Horibe <[email protected]>

* fix typo

Signed-off-by: Takamasa Horibe <[email protected]>

* move lateral and longitudinal distance calculation to util

Signed-off-by: Takamasa Horibe <[email protected]>

* simplify mergeShift function

Signed-off-by: Takamasa Horibe <[email protected]>

* fix format

Signed-off-by: Takamasa Horibe <[email protected]>

* fix typo

Signed-off-by: Takamasa Horibe <[email protected]>

* fix readme style

Signed-off-by: Takamasa Horibe <[email protected]>

* revert unexpected changes

Signed-off-by: Takamasa Horibe <[email protected]>

* - remove unused comment
- translate to english

Signed-off-by: Takamasa Horibe <[email protected]>

* apply format

Signed-off-by: Takamasa Horibe <[email protected]>

* fix typo

Signed-off-by: Takamasa Horibe <[email protected]>

* Fix/update velocity limit topic name (autowarefoundation#2223)

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <[email protected]>

* autoware_web_controller port to .auto (autowarefoundation#522)

* Porting to .auto

* Modified web url

* [autowere_web_controller/autoware_state_monitor/emergency_handler]fix some packages (autowarefoundation#603)

* fix vehicle_engage.js

* fix autoware_state_monitor param

* fix emergency_handler

* oh

* update autoware_state.js

* [autoware_web_controller]add readme (autowarefoundation#611)

* add png

* add readme

* Update common/util/web_controller/autoware_web_controller/README.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* apply format

* fix type

Co-authored-by: Kazuki Miyahara <[email protected]>

* fix depend

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: YamatoAndo <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: pre-commit <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: Yohei Mishina <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takeshi Miura <[email protected]>
@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Apr 19, 2022
@KeisukeShima KeisukeShima removed their assignment May 17, 2022
@KeisukeShima KeisukeShima added the type:good-first-issue Suitable for newcomers. label May 17, 2022
@stale
Copy link

stale bot commented Jul 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 16, 2022
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this issue Oct 5, 2022
keiota pushed a commit to keiota/autoware.universe that referenced this issue Aug 17, 2023
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this issue Aug 8, 2024
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this issue Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:good-first-issue Suitable for newcomers. type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

2 participants