Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty "filename" values on image nodes do not produce uniforms during ShaderGen #1045

Open
bernardkwok opened this issue Dec 2, 2020 · 0 comments
Open

Empty "filename" values on image nodes do not produce uniforms during ShaderGen #1045

bernardkwok opened this issue Dec 2, 2020 · 0 comments
Labels
Defect Defect fix ShaderGen Shader Generation change required
Milestone
1.39

Comments

@bernardkwok
Copy link

This was found externally when trying to load a document with an imagenode with an empty filename string.
Code generation is currently not producint any uniform for this so it is not possible to bind any values to it.

Also as a side-effect it means all such image inputs do not show up in MaterialXView as this parses uniforms to build the UI.
@bernardkwok bernardkwok added Defect Defect fix ShaderGen Shader Generation change required labels Dec 2, 2020
@bernardkwok bernardkwok added this to the 1.38 milestone Dec 2, 2020
@bernardkwok bernardkwok modified the milestones: 1.38, 1.39 Mar 18, 2021
ashwinbhat pushed a commit that referenced this issue Aug 23, 2022
@Tellusim
Extra input in NG_range_color4 graph (#1045)
4716c3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect Defect fix ShaderGen Shader Generation change required
Projects
None yet
Milestone
1.39
Development

No branches or pull requests
1 participant
@bernardkwok