Allow configuring resync period in file informer factory #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayank Shah <[email protected]>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
ecordell
reviewed
Sep 12, 2022
| } | ||
|
|
||
| var _ dynamicinformer.DynamicSharedInformerFactory = &Factory{} | ||
|
|
||
| // NewFileInformerFactory creates a new Factory. | ||
| func NewFileInformerFactory(log logr.Logger) (*Factory, error) { | ||
| func NewFileInformerFactory(log logr.Logger, opts FactoryOpts) (*Factory, error) { |
There was a problem hiding this comment.
If we used functional options here, like:
type FactoryOptFunc func(*FactoryOpts)
func WithResyncPeriod(resync time.Duration) FactoryOptFunc {
return func(opts *FactoryOpts) {
opts.ResyncPeriod = resync
}
}
func NewFileInformerFactory(log logr.Logger, ...opts FactoryOptFunc)Then existing call sites would continue working, but you could also pass in a new interval if you needed to:
existingFactory := NewFileInformerFactory(logger)
customResync := NewFileInformerFactory(logger, WithResyncPeriod(5*time.Minute))
ecordell
reviewed
Sep 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Signed-off-by: Mayank Shah [email protected]