You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In notify.dart the requireAuth method returns false. This is a bug because the notifications can be sent only on an authenticated connection. So, the requireAuth method should return true.
In the AbstractVerbHandler.dart, the below condition does not include pol authenticated connections. So, returning "true" from requireAuth might break the working of the notify verb. Modify the below code snippet to process the verb on the pol-authenticated connections.
if (getVerb().requiresAuth() &&!atConnectionMetadata.isAuthenticated) {
throwUnAuthenticatedException('Command cannot be executed without auth');
}
Steps to reproduce
Connection to a secondary server via the terminal
Run notify verb (without performing authentication)
Notify verb returns "data:null"
Expected behaviour
The notify verb should work on authentication connections only. When attempting to run on an unauthenticated connection an exception should be returned.
The text was updated successfully, but these errors were encountered:
A better solution here might be to overhaul the verb permission structure so instead of 'requiresAuth' we flip it to say whether or not the owner, or another atServer, or unauthenticated, can execute the verb.
Describe the bug
In notify.dart the requireAuth method returns false. This is a bug because the notifications can be sent only on an authenticated connection. So, the requireAuth method should return true.
In the AbstractVerbHandler.dart, the below condition does not include pol authenticated connections. So, returning "true" from requireAuth might break the working of the notify verb. Modify the below code snippet to process the verb on the pol-authenticated connections.
Steps to reproduce
Expected behaviour
The notify verb should work on authentication connections only. When attempting to run on an unauthenticated connection an exception should be returned.
The text was updated successfully, but these errors were encountered: