Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Plugin - call only to WP and not AP #17

Closed
ipajen opened this issue Oct 16, 2024 — with Slack · 4 comments
Closed

Add New Plugin - call only to WP and not AP #17

ipajen opened this issue Oct 16, 2024 — with Slack · 4 comments
Labels
enhancement New feature or request

Comments

Copy link
Collaborator

ipajen commented Oct 16, 2024

if I go to /wp-admin/plugin-install.php only a call is made to Wp and not to AP

plugins_api()
wp-admin/includes/plugin-install.php:173
WP_Plugin_Install_List_Table->prepare_items()
wp-admin/includes/class-wp-plugin-install-list-table.php:242

@mzalewski
Copy link

Caused by rewrite exclusion:


class AspirePress_ApiWordpressOrgRewriteRule implements AspirePress_RewriteRuleInterface
{
    use AspirePress_RewriteRuleTrait;

    public function __construct(string $apiDestination)
    {
        $this->setHostRewriteRule('api.wordpress.org', $apiDestination);
        $this->setExcludedPathRewriteRule('/plugins/info/1.2/');
    }
}

@smileBeda
Copy link

This is expected I believe, search is not currently proxied.
https://docs.aspirepress.org/aspireupdate/

@smileBeda smileBeda moved this to Todo in Project Phase 1 Oct 17, 2024
@smileBeda smileBeda added the enhancement New feature or request label Oct 17, 2024
@namithj
Copy link
Contributor

namithj commented Oct 24, 2024

@smileBeda Is this valid with the new version? Please close if resolved.

@ipajen
Copy link
Collaborator Author

ipajen commented Oct 24, 2024

Its working now, but when "Install now" is used it doesn't go to AP simular to #28

@namithj namithj closed this as completed Oct 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Project Phase 1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants